From 778021844dc19db1a21122a36d290f1330369915 Mon Sep 17 00:00:00 2001 From: Cam Saul <cam@geotip.com> Date: Wed, 3 Jun 2015 13:59:35 -0700 Subject: [PATCH] Fix issue where changing value of preview_display might not save --- src/metabase/api/meta/field.clj | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/metabase/api/meta/field.clj b/src/metabase/api/meta/field.clj index 1694ef8fa32..36c6f6cbd7d 100644 --- a/src/metabase/api/meta/field.clj +++ b/src/metabase/api/meta/field.clj @@ -39,10 +39,10 @@ {field_type FieldType special_type FieldSpecialType} (write-check Field id) - (check-500 (m/mapply upd Field id (merge {:description description ; you're allowed to unset description and special_type - :special_type special_type} ; but field_type and preview_display must be replaced - (when field_type {:field_type field_type}) ; with new non-nil values - (when preview_display {:preview_display preview_display})))) + (check-500 (m/mapply upd Field id (merge {:description description ; you're allowed to unset description and special_type + :special_type special_type} ; but field_type and preview_display must be replaced + (when field_type {:field_type field_type}) ; with new non-nil values + (when (not (nil? preview_display)) {:preview_display preview_display})))) (sel :one Field :id id)) (defendpoint GET "/:id/summary" -- GitLab