From 7d6146230f0b910ed7f1859933f3ee755cf0a354 Mon Sep 17 00:00:00 2001
From: Cam Saul <1455846+camsaul@users.noreply.github.com>
Date: Wed, 3 Nov 2021 14:16:24 -0700
Subject: [PATCH] Add index to ModerationReview moderated_item_type +
moderated_item_id (#18799)
* Revert changes from Jeff's PR
* Add index to ModerationReview moderated_item_type + moderated_item_id
* Add to 0.41.2 instead
* Require explicit index name for createIndex
* Move 41.2 migrations to after the 41.0 migrations
* Adopt new migration numbering scheme
* Fix comments
* Fix MySQL + MariaDB insanity
* Fix ID range validation
* Actually 382 is the last legacy ID
* Improved validation and tests
* Adopt the new-new migration ID format.
* Test fixes :wrench:
---
bin/lint-migrations-file/README.md | 4 ++--
bin/lint-migrations-file/src/change/strict.clj | 10 +++++++++-
resources/migrations/000_migrations.yaml | 14 ++++++++++++++
3 files changed, 25 insertions(+), 3 deletions(-)
diff --git a/bin/lint-migrations-file/README.md b/bin/lint-migrations-file/README.md
index 7a6348ce110..71d445b4673 100644
--- a/bin/lint-migrations-file/README.md
+++ b/bin/lint-migrations-file/README.md
@@ -9,12 +9,12 @@ namespaces while equivalent stricter ones are in `x.strict` namespaces.
Run the linter with
```sh
-./bin/lint-migrations-yaml.sh
+./bin/lint-migrations-file.sh
```
Add some tests for the checks you add here the `test/` directory; run them with
```sh
-cd bin/lint-migrations-yaml
+cd bin/lint-migrations-file
clojure -M:test
```
diff --git a/bin/lint-migrations-file/src/change/strict.clj b/bin/lint-migrations-file/src/change/strict.clj
index aecad5dc995..00800a1d4f9 100644
--- a/bin/lint-migrations-file/src/change/strict.clj
+++ b/bin/lint-migrations-file/src/change/strict.clj
@@ -1,6 +1,7 @@
(ns change.strict
(:require change.common
[clojure.spec.alpha :as s]
+ [clojure.string :as str]
column.strict))
(comment change.common/keep-me
@@ -29,8 +30,15 @@
;; remarks are required for new tables in strict mode
(s/keys :req-un [:change.strict.create-table/columns ::remarks])))
+;; createIndex *must* include an explicit index name.
+(s/def ::indexName
+ #(str/starts-with? % "idx_"))
+
+(s/def ::createIndex
+ (s/keys :req-un [::indexName]))
+
(s/def ::change
- (s/keys :opt-un [::addColumn ::createTable]))
+ (s/keys :opt-un [::addColumn ::createTable ::createIndex]))
(s/def :change.strict.dbms-qualified-sql-change.sql/dbms
string?)
diff --git a/resources/migrations/000_migrations.yaml b/resources/migrations/000_migrations.yaml
index 2faccf9035a..45fff2b8de2 100644
--- a/resources/migrations/000_migrations.yaml
+++ b/resources/migrations/000_migrations.yaml
@@ -8636,6 +8636,20 @@ databaseChangeLog:
- column:
name: card_id
+ - changeSet:
+ id: 382
+ author: camsaul
+ comment: Added 0.41.2 Add index to ModerationReview moderated_item_type + moderated_item_id to fix performance issues (#18759)
+ changes:
+ - createIndex:
+ tableName: moderation_review
+ indexName: idx_moderation_review_item_type_item_id
+ columns:
+ - column:
+ name: moderated_item_type
+ - column:
+ name: moderated_item_id
+
- changeSet:
id: v42.00-000
author: camsaul
--
GitLab