From 7dde1ed971ade116fa621b686948b1dcb2d8263d Mon Sep 17 00:00:00 2001
From: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Date: Mon, 17 Jul 2023 15:13:13 +0200
Subject: [PATCH] Fix missing React keys in embedding settings page (#32396)
* Fix missing React keys in embedding settings page
[Resolves: ##32395]
* Address code review comments
We're adding prefix `-` to the keys that are not meant to represent backend settings.
---
frontend/src/metabase/admin/settings/selectors.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/frontend/src/metabase/admin/settings/selectors.js b/frontend/src/metabase/admin/settings/selectors.js
index e8a6f670e38..b26764b1195 100644
--- a/frontend/src/metabase/admin/settings/selectors.js
+++ b/frontend/src/metabase/admin/settings/selectors.js
@@ -471,6 +471,7 @@ const SECTIONS = {
getHidden: (_, derivedSettings) => !derivedSettings["enable-embedding"],
},
{
+ key: "-standalone-embeds",
widget: EmbeddingOption,
getHidden: (_, derivedSettings) => !derivedSettings["enable-embedding"],
embedName: t`Standalone embeds`,
@@ -478,6 +479,7 @@ const SECTIONS = {
embedType: "standalone",
},
{
+ key: "-full-app-embedding",
widget: EmbeddingOption,
getHidden: (_, derivedSettings) => !derivedSettings["enable-embedding"],
embedName: t`Full-app embedding`,
--
GitLab