diff --git a/frontend/src/metabase/actions/containers/ActionCreator/InlineActionSettings.tsx b/frontend/src/metabase/actions/containers/ActionCreator/InlineActionSettings.tsx index 650d049899f80243c1cfb24ec25a0becc9d2fdd8..f4f79c5338311b5b51c91744e553a1da01b1737d 100644 --- a/frontend/src/metabase/actions/containers/ActionCreator/InlineActionSettings.tsx +++ b/frontend/src/metabase/actions/containers/ActionCreator/InlineActionSettings.tsx @@ -130,7 +130,7 @@ const InlineActionSettings = ({ {action && hasSharingPermission && ( <FormField title={t`Make public`} - description={t`Creates a publicly shareable link to this action.`} + description={t`Creates a publicly shareable link to this action form.`} orientation="horizontal" htmlFor={`${id}-public`} > @@ -145,7 +145,7 @@ const InlineActionSettings = ({ <CopyWidgetContainer> <CopyWidget value={Urls.publicAction(siteUrl, action.public_uuid)} - aria-label={t`Public action link URL`} + aria-label={t`Public action form URL`} /> </CopyWidgetContainer> )} diff --git a/frontend/src/metabase/actions/containers/ActionCreator/tests/ActionCreator-Sharing.unit.spec.tsx b/frontend/src/metabase/actions/containers/ActionCreator/tests/ActionCreator-Sharing.unit.spec.tsx index ef8147f1dc813bceb9d3d91a1f9f77adefcdca8d..6ffe7b2de4c29fa61410834f73bfe4de7684be6c 100644 --- a/frontend/src/metabase/actions/containers/ActionCreator/tests/ActionCreator-Sharing.unit.spec.tsx +++ b/frontend/src/metabase/actions/containers/ActionCreator/tests/ActionCreator-Sharing.unit.spec.tsx @@ -59,7 +59,7 @@ describe("ActionCreator > Sharing", () => { }); expect(makePublicToggle).not.toBeChecked(); expect( - screen.queryByRole("textbox", { name: "Public action link URL" }), + screen.queryByRole("textbox", { name: "Public action form URL" }), ).not.toBeInTheDocument(); screen.getByRole("switch", { name: "Make public" }).click(); @@ -70,7 +70,7 @@ describe("ActionCreator > Sharing", () => { const expectedPublicLinkUrl = `${SITE_URL}/public/action/${mockUuid}`; expect( - screen.getByRole("textbox", { name: "Public action link URL" }), + screen.getByRole("textbox", { name: "Public action form URL" }), ).toHaveValue(expectedPublicLinkUrl); }); @@ -89,7 +89,7 @@ describe("ActionCreator > Sharing", () => { expect(makePublicToggle).toBeChecked(); const expectedPublicLinkUrl = `${SITE_URL}/public/action/${mockUuid}`; expect( - screen.getByRole("textbox", { name: "Public action link URL" }), + screen.getByRole("textbox", { name: "Public action form URL" }), ).toHaveValue(expectedPublicLinkUrl); makePublicToggle.click(); @@ -103,7 +103,7 @@ describe("ActionCreator > Sharing", () => { }); expect( - screen.queryByRole("textbox", { name: "Public action link URL" }), + screen.queryByRole("textbox", { name: "Public action form URL" }), ).not.toBeInTheDocument(); }); }); diff --git a/frontend/src/metabase/admin/settings/components/widgets/PublicLinksListing/PublicLinksListing.jsx b/frontend/src/metabase/admin/settings/components/widgets/PublicLinksListing/PublicLinksListing.jsx index 5fee6facf4b8e7d9987764f094d8b934d9beae7f..6ee55721bb3244bd4781210b1df306483794b53c 100644 --- a/frontend/src/metabase/admin/settings/components/widgets/PublicLinksListing/PublicLinksListing.jsx +++ b/frontend/src/metabase/admin/settings/components/widgets/PublicLinksListing/PublicLinksListing.jsx @@ -161,7 +161,7 @@ export const PublicLinksActionListing = connect(mapStateToProps)( <PublicLinksListing load={ActionsApi.listPublic} revoke={ActionsApi.deletePublicLink} - type={t`Public Action Listing`} + type={t`Public Action Form Listing`} getUrl={action => Urls.action({ id: action.model_id }, action.id)} getPublicUrl={({ public_uuid }) => Urls.publicAction(siteUrl, public_uuid) diff --git a/frontend/src/metabase/admin/settings/selectors.js b/frontend/src/metabase/admin/settings/selectors.js index d82d10cbe014063b6c51053784bdfbd1c7eb6a37..6bcbdd682db3d51e2d987b980885ce81c823515f 100644 --- a/frontend/src/metabase/admin/settings/selectors.js +++ b/frontend/src/metabase/admin/settings/selectors.js @@ -329,7 +329,7 @@ const SECTIONS = updateSectionsWithPlugins({ }, { key: "-public-sharing-actions", - display_name: t`Shared Actions`, + display_name: t`Shared Action Forms`, widget: PublicLinksActionListing, getHidden: settings => !settings["enable-public-sharing"], }, diff --git a/frontend/src/metabase/models/components/ModelDetailPage/ModelActionDetails/ModelActionListItem.tsx b/frontend/src/metabase/models/components/ModelDetailPage/ModelActionDetails/ModelActionListItem.tsx index e5c3e3322e0e2796808b16f1dbeb740dd7eb4297..43744c24c0f1b3fe4a6227d2debda51c2fa57182 100644 --- a/frontend/src/metabase/models/components/ModelDetailPage/ModelActionDetails/ModelActionListItem.tsx +++ b/frontend/src/metabase/models/components/ModelDetailPage/ModelActionDetails/ModelActionListItem.tsx @@ -85,7 +85,7 @@ function ModelActionListItem({ <ActionTitle to={actionUrl}>{action.name}</ActionTitle> <ActionSubtitle> {action.public_uuid && ( - <ActionSubtitlePart>{t`Public Action`}</ActionSubtitlePart> + <ActionSubtitlePart>{t`Public action form`}</ActionSubtitlePart> )} {action.creator && ( <ActionSubtitlePart> diff --git a/frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.unit.spec.tsx b/frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.unit.spec.tsx index b381ddad4652aa2c32339bd4a1ed3406056b0653..f188124c45b9bb28c068ff107321034f9304f042 100644 --- a/frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.unit.spec.tsx +++ b/frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.unit.spec.tsx @@ -549,7 +549,7 @@ describe("ModelDetailPage", () => { expect(screen.getByText(action.name)).toBeInTheDocument(); expect(screen.getByText(TEST_QUERY)).toBeInTheDocument(); - expect(screen.getByText("Public Action")).toBeInTheDocument(); + expect(screen.getByText("Public action form")).toBeInTheDocument(); expect( screen.getByText(`Created by ${action.creator.common_name}`), ).toBeInTheDocument(); diff --git a/frontend/test/metabase/scenarios/admin/settings/public-sharing.cy.spec.js b/frontend/test/metabase/scenarios/admin/settings/public-sharing.cy.spec.js index f401b613fdef3f231ba0aa1e6bd5018610015325..1921ce5f4a0bdcdfd320d09911ed42ac96cb75a9 100644 --- a/frontend/test/metabase/scenarios/admin/settings/public-sharing.cy.spec.js +++ b/frontend/test/metabase/scenarios/admin/settings/public-sharing.cy.spec.js @@ -215,7 +215,7 @@ describe("scenarios > admin > settings > public sharing", () => { cy.visit("/admin/settings/public-sharing"); - cy.findByText("Shared Actions").should("be.visible"); + cy.findByText("Shared Action Forms").should("be.visible"); cy.findByText(expectedActionName).should("be.visible"); cy.get("@actionUuid").then(actionUuid => { cy.findByText(`${location.origin}/public/action/${actionUuid}`).click(); diff --git a/frontend/test/metabase/scenarios/models/model-actions.cy.spec.js b/frontend/test/metabase/scenarios/models/model-actions.cy.spec.js index 91d18ed00c46b113db129a057d84c35f0fc64228..7d1c7a40b55290688c923a8466a2f719291a1193 100644 --- a/frontend/test/metabase/scenarios/models/model-actions.cy.spec.js +++ b/frontend/test/metabase/scenarios/models/model-actions.cy.spec.js @@ -318,7 +318,7 @@ function enableSharingFor(actionName, { publicUrlAlias }) { cy.findByRole("dialog").within(() => { cy.button("Action settings").click(); cy.findByLabelText("Make public").should("not.be.checked").click(); - cy.findByLabelText("Public action link URL") + cy.findByLabelText("Public action form URL") .invoke("val") .then(url => { cy.wrap(url).as(publicUrlAlias);