From 7e104e717df070da990336edc31812abe09b0739 Mon Sep 17 00:00:00 2001
From: Alexander Polyankin <alexander.polyankin@metabase.com>
Date: Mon, 20 Feb 2023 20:49:21 +0200
Subject: [PATCH] Rename "public actions" to "public action forms" (#28456)
---
.../containers/ActionCreator/InlineActionSettings.tsx | 4 ++--
.../tests/ActionCreator-Sharing.unit.spec.tsx | 8 ++++----
.../widgets/PublicLinksListing/PublicLinksListing.jsx | 2 +-
frontend/src/metabase/admin/settings/selectors.js | 2 +-
.../ModelActionDetails/ModelActionListItem.tsx | 2 +-
.../ModelDetailPage/ModelDetailPage.unit.spec.tsx | 2 +-
.../scenarios/admin/settings/public-sharing.cy.spec.js | 2 +-
.../metabase/scenarios/models/model-actions.cy.spec.js | 2 +-
8 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/frontend/src/metabase/actions/containers/ActionCreator/InlineActionSettings.tsx b/frontend/src/metabase/actions/containers/ActionCreator/InlineActionSettings.tsx
index 650d049899f..f4f79c53383 100644
--- a/frontend/src/metabase/actions/containers/ActionCreator/InlineActionSettings.tsx
+++ b/frontend/src/metabase/actions/containers/ActionCreator/InlineActionSettings.tsx
@@ -130,7 +130,7 @@ const InlineActionSettings = ({
{action && hasSharingPermission && (
<FormField
title={t`Make public`}
- description={t`Creates a publicly shareable link to this action.`}
+ description={t`Creates a publicly shareable link to this action form.`}
orientation="horizontal"
htmlFor={`${id}-public`}
>
@@ -145,7 +145,7 @@ const InlineActionSettings = ({
<CopyWidgetContainer>
<CopyWidget
value={Urls.publicAction(siteUrl, action.public_uuid)}
- aria-label={t`Public action link URL`}
+ aria-label={t`Public action form URL`}
/>
</CopyWidgetContainer>
)}
diff --git a/frontend/src/metabase/actions/containers/ActionCreator/tests/ActionCreator-Sharing.unit.spec.tsx b/frontend/src/metabase/actions/containers/ActionCreator/tests/ActionCreator-Sharing.unit.spec.tsx
index ef8147f1dc8..6ffe7b2de4c 100644
--- a/frontend/src/metabase/actions/containers/ActionCreator/tests/ActionCreator-Sharing.unit.spec.tsx
+++ b/frontend/src/metabase/actions/containers/ActionCreator/tests/ActionCreator-Sharing.unit.spec.tsx
@@ -59,7 +59,7 @@ describe("ActionCreator > Sharing", () => {
});
expect(makePublicToggle).not.toBeChecked();
expect(
- screen.queryByRole("textbox", { name: "Public action link URL" }),
+ screen.queryByRole("textbox", { name: "Public action form URL" }),
).not.toBeInTheDocument();
screen.getByRole("switch", { name: "Make public" }).click();
@@ -70,7 +70,7 @@ describe("ActionCreator > Sharing", () => {
const expectedPublicLinkUrl = `${SITE_URL}/public/action/${mockUuid}`;
expect(
- screen.getByRole("textbox", { name: "Public action link URL" }),
+ screen.getByRole("textbox", { name: "Public action form URL" }),
).toHaveValue(expectedPublicLinkUrl);
});
@@ -89,7 +89,7 @@ describe("ActionCreator > Sharing", () => {
expect(makePublicToggle).toBeChecked();
const expectedPublicLinkUrl = `${SITE_URL}/public/action/${mockUuid}`;
expect(
- screen.getByRole("textbox", { name: "Public action link URL" }),
+ screen.getByRole("textbox", { name: "Public action form URL" }),
).toHaveValue(expectedPublicLinkUrl);
makePublicToggle.click();
@@ -103,7 +103,7 @@ describe("ActionCreator > Sharing", () => {
});
expect(
- screen.queryByRole("textbox", { name: "Public action link URL" }),
+ screen.queryByRole("textbox", { name: "Public action form URL" }),
).not.toBeInTheDocument();
});
});
diff --git a/frontend/src/metabase/admin/settings/components/widgets/PublicLinksListing/PublicLinksListing.jsx b/frontend/src/metabase/admin/settings/components/widgets/PublicLinksListing/PublicLinksListing.jsx
index 5fee6facf4b..6ee55721bb3 100644
--- a/frontend/src/metabase/admin/settings/components/widgets/PublicLinksListing/PublicLinksListing.jsx
+++ b/frontend/src/metabase/admin/settings/components/widgets/PublicLinksListing/PublicLinksListing.jsx
@@ -161,7 +161,7 @@ export const PublicLinksActionListing = connect(mapStateToProps)(
<PublicLinksListing
load={ActionsApi.listPublic}
revoke={ActionsApi.deletePublicLink}
- type={t`Public Action Listing`}
+ type={t`Public Action Form Listing`}
getUrl={action => Urls.action({ id: action.model_id }, action.id)}
getPublicUrl={({ public_uuid }) =>
Urls.publicAction(siteUrl, public_uuid)
diff --git a/frontend/src/metabase/admin/settings/selectors.js b/frontend/src/metabase/admin/settings/selectors.js
index d82d10cbe01..6bcbdd682db 100644
--- a/frontend/src/metabase/admin/settings/selectors.js
+++ b/frontend/src/metabase/admin/settings/selectors.js
@@ -329,7 +329,7 @@ const SECTIONS = updateSectionsWithPlugins({
},
{
key: "-public-sharing-actions",
- display_name: t`Shared Actions`,
+ display_name: t`Shared Action Forms`,
widget: PublicLinksActionListing,
getHidden: settings => !settings["enable-public-sharing"],
},
diff --git a/frontend/src/metabase/models/components/ModelDetailPage/ModelActionDetails/ModelActionListItem.tsx b/frontend/src/metabase/models/components/ModelDetailPage/ModelActionDetails/ModelActionListItem.tsx
index e5c3e3322e0..43744c24c0f 100644
--- a/frontend/src/metabase/models/components/ModelDetailPage/ModelActionDetails/ModelActionListItem.tsx
+++ b/frontend/src/metabase/models/components/ModelDetailPage/ModelActionDetails/ModelActionListItem.tsx
@@ -85,7 +85,7 @@ function ModelActionListItem({
<ActionTitle to={actionUrl}>{action.name}</ActionTitle>
<ActionSubtitle>
{action.public_uuid && (
- <ActionSubtitlePart>{t`Public Action`}</ActionSubtitlePart>
+ <ActionSubtitlePart>{t`Public action form`}</ActionSubtitlePart>
)}
{action.creator && (
<ActionSubtitlePart>
diff --git a/frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.unit.spec.tsx b/frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.unit.spec.tsx
index b381ddad465..f188124c45b 100644
--- a/frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.unit.spec.tsx
+++ b/frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.unit.spec.tsx
@@ -549,7 +549,7 @@ describe("ModelDetailPage", () => {
expect(screen.getByText(action.name)).toBeInTheDocument();
expect(screen.getByText(TEST_QUERY)).toBeInTheDocument();
- expect(screen.getByText("Public Action")).toBeInTheDocument();
+ expect(screen.getByText("Public action form")).toBeInTheDocument();
expect(
screen.getByText(`Created by ${action.creator.common_name}`),
).toBeInTheDocument();
diff --git a/frontend/test/metabase/scenarios/admin/settings/public-sharing.cy.spec.js b/frontend/test/metabase/scenarios/admin/settings/public-sharing.cy.spec.js
index f401b613fde..1921ce5f4a0 100644
--- a/frontend/test/metabase/scenarios/admin/settings/public-sharing.cy.spec.js
+++ b/frontend/test/metabase/scenarios/admin/settings/public-sharing.cy.spec.js
@@ -215,7 +215,7 @@ describe("scenarios > admin > settings > public sharing", () => {
cy.visit("/admin/settings/public-sharing");
- cy.findByText("Shared Actions").should("be.visible");
+ cy.findByText("Shared Action Forms").should("be.visible");
cy.findByText(expectedActionName).should("be.visible");
cy.get("@actionUuid").then(actionUuid => {
cy.findByText(`${location.origin}/public/action/${actionUuid}`).click();
diff --git a/frontend/test/metabase/scenarios/models/model-actions.cy.spec.js b/frontend/test/metabase/scenarios/models/model-actions.cy.spec.js
index 91d18ed00c4..7d1c7a40b55 100644
--- a/frontend/test/metabase/scenarios/models/model-actions.cy.spec.js
+++ b/frontend/test/metabase/scenarios/models/model-actions.cy.spec.js
@@ -318,7 +318,7 @@ function enableSharingFor(actionName, { publicUrlAlias }) {
cy.findByRole("dialog").within(() => {
cy.button("Action settings").click();
cy.findByLabelText("Make public").should("not.be.checked").click();
- cy.findByLabelText("Public action link URL")
+ cy.findByLabelText("Public action form URL")
.invoke("val")
.then(url => {
cy.wrap(url).as(publicUrlAlias);
--
GitLab