diff --git a/frontend/src/metabase/lib/expressions/suggest.js b/frontend/src/metabase/lib/expressions/suggest.js index 94190ccefd68d8ed3d26fd0d2227a9d7cc333ff3..1c1d4c2271504f5d5ce7af530543ab6255bdd76a 100644 --- a/frontend/src/metabase/lib/expressions/suggest.js +++ b/frontend/src/metabase/lib/expressions/suggest.js @@ -251,6 +251,11 @@ export function suggest({ ), ), ); + finalSuggestions.push( + ...["sum-where", "count-where", "share"].map(short => + functionSuggestion("aggregations", short, true), + ), + ); functions = FUNCTIONS_BY_TYPE["number"]; } else { functions = FUNCTIONS_BY_TYPE[expectedType]; diff --git a/frontend/test/metabase/lib/expressions/suggest.unit.spec.js b/frontend/test/metabase/lib/expressions/suggest.unit.spec.js index 9ff1bb23b760e7208013a3419e86ba4768e36c4a..c5d21de72dc66213dbed25cf3639551c09d0d872 100644 --- a/frontend/test/metabase/lib/expressions/suggest.unit.spec.js +++ b/frontend/test/metabase/lib/expressions/suggest.unit.spec.js @@ -15,13 +15,16 @@ import { ORDERS, REVIEWS } from "__support__/sample_dataset_fixture"; const AGGREGATION_FUNCTIONS = [ { type: "aggregations", text: "Average(" }, { type: "aggregations", text: "Count " }, + { type: "aggregations", text: "CountIf(" }, { type: "aggregations", text: "CumulativeCount " }, { type: "aggregations", text: "CumulativeSum(" }, { type: "aggregations", text: "Distinct(" }, { type: "aggregations", text: "Max(" }, { type: "aggregations", text: "Min(" }, + { type: "aggregations", text: "Share(" }, { type: "aggregations", text: "StandardDeviation(" }, { type: "aggregations", text: "Sum(" }, + { type: "aggregations", text: "SumIf(" }, ]; const STRING_FUNCTIONS = [ { text: "concat(", type: "functions" }, @@ -305,6 +308,7 @@ describe("metabase/lib/expression/suggest", () => { it("should suggest partial matches in aggregation", () => { expect(suggest({ source: "1 + C", ...aggregationOpts })).toEqual([ { type: "aggregations", text: "Count " }, + { type: "aggregations", text: "CountIf(" }, { type: "aggregations", text: "CumulativeCount " }, { type: "aggregations", text: "CumulativeSum(" }, ]);