From 80f4b6d1893d8bf547db20114e9c3ad9114079f1 Mon Sep 17 00:00:00 2001
From: Kyle Doherty <kdoh@users.noreply.github.com>
Date: Fri, 7 Apr 2017 10:36:05 -0600
Subject: [PATCH] handle display of 0 in the number picker (#4689)
* handle 0
* cleanup
---
.../components/filters/pickers/NumberPicker.jsx | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/frontend/src/metabase/query_builder/components/filters/pickers/NumberPicker.jsx b/frontend/src/metabase/query_builder/components/filters/pickers/NumberPicker.jsx
index 204594f7621..910842392f5 100644
--- a/frontend/src/metabase/query_builder/components/filters/pickers/NumberPicker.jsx
+++ b/frontend/src/metabase/query_builder/components/filters/pickers/NumberPicker.jsx
@@ -23,7 +23,13 @@ export default class NumberPicker extends Component<*, Props, State> {
constructor(props: Props) {
super(props);
this.state = {
- stringValues: props.values.map(v => String(v || "")),
+ stringValues: props.values.map(v => {
+ if(typeof v === 'number') {
+ return String(v)
+ } else {
+ return String(v || "")
+ }
+ }),
validations: this._validate(props.values)
}
}
--
GitLab