From 88b3b536f9e4c69715a94101cf8de3a7069951a8 Mon Sep 17 00:00:00 2001
From: Alexander Lesnenko <alxnddr@users.noreply.github.com>
Date: Tue, 3 Aug 2021 20:18:12 +0300
Subject: [PATCH] Fix incorrect props are passed to CollectionPermissionModal
when used for snippets folders (#17284)
---
enterprise/frontend/src/metabase-enterprise/snippets/index.js | 2 +-
.../scenarios/native/snippets/snippet-permissions.cy.spec.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/enterprise/frontend/src/metabase-enterprise/snippets/index.js b/enterprise/frontend/src/metabase-enterprise/snippets/index.js
index cd795ee973c..011b246ec21 100644
--- a/enterprise/frontend/src/metabase-enterprise/snippets/index.js
+++ b/enterprise/frontend/src/metabase-enterprise/snippets/index.js
@@ -51,7 +51,7 @@ PLUGIN_SNIPPET_SIDEBAR_MODALS.push(
>
<CollectionPermissionsModal
params={{
- collectionId: snippetSidebar.state.permissionsModalCollectionId,
+ slug: snippetSidebar.state.permissionsModalCollectionId,
}}
onClose={() =>
snippetSidebar.setState({ permissionsModalCollectionId: null })
diff --git a/frontend/test/metabase/scenarios/native/snippets/snippet-permissions.cy.spec.js b/frontend/test/metabase/scenarios/native/snippets/snippet-permissions.cy.spec.js
index 2c4c93cfa18..fb019f2478c 100644
--- a/frontend/test/metabase/scenarios/native/snippets/snippet-permissions.cy.spec.js
+++ b/frontend/test/metabase/scenarios/native/snippets/snippet-permissions.cy.spec.js
@@ -179,7 +179,7 @@ describeWithToken("scenarios > question > snippets", () => {
cy.findByText("Snippet Folder").should("not.exist");
});
- it.skip("shouldn't update root permissions when changing permissions on a created folder (metabase#17268)", () => {
+ it("shouldn't update root permissions when changing permissions on a created folder (metabase#17268)", () => {
cy.intercept("PUT", "/api/collection/graph").as("updatePermissions");
openNativeEditor();
--
GitLab