From 8ed9973721333447151741c4829f41217ebb11cd Mon Sep 17 00:00:00 2001
From: Gustavo Saiani <gus@metabase.com>
Date: Mon, 10 Oct 2022 10:39:14 -0300
Subject: [PATCH] Show "Learn about your data" info on fresh model page
(#25817)
---
.../metabase-lib/lib/queries/utils/native-query-table.ts | 2 +-
.../lib/queries/utils/structured-query-table.ts | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/frontend/src/metabase-lib/lib/queries/utils/native-query-table.ts b/frontend/src/metabase-lib/lib/queries/utils/native-query-table.ts
index effd43a60ec..a134de119b0 100644
--- a/frontend/src/metabase-lib/lib/queries/utils/native-query-table.ts
+++ b/frontend/src/metabase-lib/lib/queries/utils/native-query-table.ts
@@ -7,7 +7,7 @@ import { getDatasetTable } from "./nested-card-query-table";
export function getNativeQueryTable(nativeQuery: NativeQuery): Table | null {
const question = nativeQuery.question();
- const isDataset = question?.isDataset();
+ const isDataset = question?.isDataset() && question.isSaved();
if (isDataset) {
return getDatasetTable(nativeQuery);
diff --git a/frontend/src/metabase-lib/lib/queries/utils/structured-query-table.ts b/frontend/src/metabase-lib/lib/queries/utils/structured-query-table.ts
index e14467c3819..d53a72aab31 100644
--- a/frontend/src/metabase-lib/lib/queries/utils/structured-query-table.ts
+++ b/frontend/src/metabase-lib/lib/queries/utils/structured-query-table.ts
@@ -20,15 +20,15 @@ export function getStructuredQueryTable(query: StructuredQuery): Table | null {
return getNestedCardTable(query);
}
- // 3. The query's question is a dataset.
+ // 3. The query's question is a saved dataset.
const question = query.question();
- const isDataset = question?.isDataset() ?? false;
+ const isDataset = question?.isDataset() && question.isSaved();
if (isDataset) {
return getDatasetTable(query);
}
// 4. The query's table is a concrete table, assuming one exists in `metadata`.
- // Faiure to find a table at this point indicates that there is a bug.
+ // Failure to find a table at this point indicates that there is a bug.
return query.metadata().table(sourceTableId);
}
--
GitLab