From 8efb7d4162b5cab9cded43b745eb502ea24d55f8 Mon Sep 17 00:00:00 2001
From: Nick Fitzpatrick <nick@metabase.com>
Date: Wed, 16 Nov 2022 19:18:52 -0400
Subject: [PATCH] Wrap sidebar actions in Query Builder View Footer (#26553)
---
.../metabase/query_builder/components/view/ViewFooter.jsx | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/frontend/src/metabase/query_builder/components/view/ViewFooter.jsx b/frontend/src/metabase/query_builder/components/view/ViewFooter.jsx
index 8bb2455247d..5b58fa53bb7 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewFooter.jsx
+++ b/frontend/src/metabase/query_builder/components/view/ViewFooter.jsx
@@ -83,7 +83,9 @@ const ViewFooter = ({
result={result}
active={isShowingChartTypeSidebar}
onClick={
- isShowingChartTypeSidebar ? onCloseChartType : onOpenChartType
+ isShowingChartTypeSidebar
+ ? () => onCloseChartType()
+ : () => onOpenChartType()
}
/>
),
@@ -95,8 +97,8 @@ const ViewFooter = ({
active={isShowingChartSettingsSidebar}
onClick={
isShowingChartSettingsSidebar
- ? onCloseChartSettings
- : onOpenChartSettings
+ ? () => onCloseChartSettings()
+ : () => onOpenChartSettings()
}
/>
),
--
GitLab