diff --git a/src/metabase/public_settings/premium_features.clj b/src/metabase/public_settings/premium_features.clj index 647db27d352c4fec8c623b73c38ee80b214ce0c6..1d47dd0f6c3891c005ede4ace00d84e8c08ba2d8 100644 --- a/src/metabase/public_settings/premium_features.clj +++ b/src/metabase/public_settings/premium_features.clj @@ -262,6 +262,7 @@ (defsetting premium-embedding-token ; TODO - rename this to premium-features-token? (deferred-tru "Token for premium features. Go to the MetaStore to get yours!") :audit :never + :sensitive? true :setter (fn [new-value] ;; validate the new value if we're not unsetting it diff --git a/test/metabase/api/session_test.clj b/test/metabase/api/session_test.clj index af87bf6ff91f7edb9acd5b70178194adcef119d5..2bf18a017158fb2969864fd66bbbb5a24ffb02a2 100644 --- a/test/metabase/api/session_test.clj +++ b/test/metabase/api/session_test.clj @@ -469,6 +469,18 @@ (-> (mt/client :get 200 "session/properties" {:request-options {:headers {"x-metabase-locale" "es"}}}) :engines :h2 :details-fields first :display-name))))))) +(deftest properties-skip-sensitive-test + (reset-throttlers!) + (testing "GET /session/properties" + (testing "don't return the token for admins" + (is (= nil + (-> (mt/client :get 200 "session/properties" (mt/user->credentials :crowberto)) + keys #{:premium-embedding-token})))) + (testing "don't return the token for non-admins" + (is (= nil + (-> (mt/client :get 200 "session/properties" (mt/user->credentials :rasta)) + keys #{:premium-embedding-token})))))) + ;;; ------------------------------------------- TESTS FOR GOOGLE SIGN-IN --------------------------------------------- (deftest google-auth-test