From 92428fa629eb685b6f5d9d02cdf270cda1841bf9 Mon Sep 17 00:00:00 2001
From: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Date: Tue, 11 May 2021 21:54:07 +0200
Subject: [PATCH] Use GitHub Actions to run front-end tests (#15507) (#16001)
- Cherry picks 274be949d5ba27a323ebba93e3636f1c41090442 from `master`, which extracted unit and timezone tests from CircleCi and made them run using GitHub actions
- Synchronizes the "state" between the `master` and `release-x.39.x` branches
Co-authored-by: Ariya Hidayat <ariya@metabase.com>
---
.circleci/config.yml | 22 --------------------
.github/workflows/frontend.yml | 38 +++++++++++++++++++++++++++++++++-
2 files changed, 37 insertions(+), 23 deletions(-)
diff --git a/.circleci/config.yml b/.circleci/config.yml
index ba72be81ac0..4b6415be241 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -716,14 +716,6 @@ jobs:
- /home/circleci/metabase/metabase/node_modules
- /home/circleci/.cache/Cypress
- fe-tests-unit:
- executor: clojure-and-node
- steps:
- - run-yarn-command:
- command-name: Run frontend unit tests
- command: run test-unit
- skip-when-no-change: true
-
shared-tests-cljs:
executor: clojure-and-node
steps:
@@ -732,14 +724,6 @@ jobs:
command: run test-cljs
skip-when-no-change: true
- fe-tests-timezones:
- executor: clojure-and-node
- steps:
- - run-yarn-command:
- command-name: Run frontend timezone tests
- command: run test-timezones
- skip-when-no-change: true
-
# Unlike the other build-uberjar steps, this step should be run once overall and the results can be shared between
# OSS and EE uberjars.
build-uberjar-drivers:
@@ -1169,15 +1153,9 @@ workflows:
- fe-deps:
requires:
- checkout
- - fe-tests-unit:
- requires:
- - fe-deps
- shared-tests-cljs:
requires:
- fe-deps
- - fe-tests-timezones:
- requires:
- - fe-deps
- fe-tests-cypress:
matrix:
diff --git a/.github/workflows/frontend.yml b/.github/workflows/frontend.yml
index d0b1c78e773..4ebee9f2ac2 100644
--- a/.github/workflows/frontend.yml
+++ b/.github/workflows/frontend.yml
@@ -16,7 +16,7 @@ on:
- 'shared/**'
- 'enterprise/frontend/**'
- 'docs/**'
- - '**/package.lock'
+ - '**/package.json'
- '**/yarn.lock'
- '.github/workflows/**'
@@ -75,3 +75,39 @@ jobs:
- run: yarn install --frozen-lockfile --prefer-offline
- run: yarn run lint-docs-links
name: Run docs links checker
+
+ fe-tests-unit:
+ runs-on: ubuntu-20.04
+ timeout-minutes: 10
+ steps:
+ - uses: actions/checkout@v2
+ - name: Prepare Node.js
+ uses: actions/setup-node@v1
+ with:
+ node-version: 14.x
+ - name: Get yarn cache
+ uses: actions/cache@v2
+ with:
+ path: ~/.cache/yarn
+ key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+ - run: yarn install --frozen-lockfile --prefer-offline
+ - run: yarn run test-unit
+ name: Run frontend unit tests
+
+ fe-tests-timezones:
+ runs-on: ubuntu-20.04
+ timeout-minutes: 10
+ steps:
+ - uses: actions/checkout@v2
+ - name: Prepare Node.js
+ uses: actions/setup-node@v1
+ with:
+ node-version: 14.x
+ - name: Get yarn cache
+ uses: actions/cache@v2
+ with:
+ path: ~/.cache/yarn
+ key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+ - run: yarn install --frozen-lockfile --prefer-offline
+ - run: yarn run test-timezones
+ name: Run frontend timezones tests
--
GitLab