diff --git a/enterprise/frontend/src/metabase-enterprise/embedding/index.js b/enterprise/frontend/src/metabase-enterprise/embedding/index.js index 29083da36c66646650228ded6b10b8be60888706..38571c3710d0e3271175ee8f3c9efa792d899a27 100644 --- a/enterprise/frontend/src/metabase-enterprise/embedding/index.js +++ b/enterprise/frontend/src/metabase-enterprise/embedding/index.js @@ -40,7 +40,7 @@ const APP_ORIGIN_SETTING = { PLUGIN_ADMIN_SETTINGS_UPDATES.push(sections => updateIn( sections, - ["embedding_in_other_applications/full-app", "settings"], + ["embedding-in-other-applications/full-app", "settings"], settings => { return [...settings, APP_ORIGIN_SETTING]; }, diff --git a/frontend/src/metabase/admin/settings/components/widgets/EmbeddingOption/EmbeddingOption.tsx b/frontend/src/metabase/admin/settings/components/widgets/EmbeddingOption/EmbeddingOption.tsx index b6904dada62cdfb2ef03bb828341b231dfef2013..5e710644b49b4b44301aa5754eee9f967d3e463f 100644 --- a/frontend/src/metabase/admin/settings/components/widgets/EmbeddingOption/EmbeddingOption.tsx +++ b/frontend/src/metabase/admin/settings/components/widgets/EmbeddingOption/EmbeddingOption.tsx @@ -21,7 +21,7 @@ interface EmbeddingOptionProps { export default function EmbeddingOption({ setting }: EmbeddingOptionProps) { return ( <Link - to={`/admin/settings/embedding_in_other_applications/${setting.embedType}`} + to={`/admin/settings/embedding-in-other-applications/${setting.embedType}`} > <StyledCard compact> {setting.embedType === "full-app" && <Label>{t`Paid`}</Label>} diff --git a/frontend/src/metabase/admin/settings/selectors.js b/frontend/src/metabase/admin/settings/selectors.js index 31bd0f8d220ea26f58c3cdd65c489c5b7d29e392..2100e7ed8ca96237977bad61e748730dcc2feac5 100644 --- a/frontend/src/metabase/admin/settings/selectors.js +++ b/frontend/src/metabase/admin/settings/selectors.js @@ -306,7 +306,7 @@ const SECTIONS = updateSectionsWithPlugins({ }, ], }, - public_sharing: { + "public-sharing": { name: t`Public Sharing`, order: 9, settings: [ @@ -329,7 +329,7 @@ const SECTIONS = updateSectionsWithPlugins({ }, ], }, - embedding_in_other_applications: { + "embedding-in-other-applications": { name: t`Embedding`, order: 10, settings: [ @@ -387,7 +387,7 @@ const SECTIONS = updateSectionsWithPlugins({ }, ], }, - "embedding_in_other_applications/standalone": { + "embedding-in-other-applications/standalone": { settings: [ { widget: () => { @@ -397,7 +397,7 @@ const SECTIONS = updateSectionsWithPlugins({ crumbs={[ [ t`Embedding`, - "/admin/settings/embedding_in_other_applications", + "/admin/settings/embedding-in-other-applications", ], [t`Standalone embeds`], ]} @@ -432,13 +432,13 @@ const SECTIONS = updateSectionsWithPlugins({ }, { widget: () => ( - <RedirectWidget to="/admin/settings/embedding_in_other_applications" /> + <RedirectWidget to="/admin/settings/embedding-in-other-applications" /> ), getHidden: (_, derivedSettings) => derivedSettings["enable-embedding"], }, ], }, - "embedding_in_other_applications/full-app": { + "embedding-in-other-applications/full-app": { settings: [ { widget: () => { @@ -448,7 +448,7 @@ const SECTIONS = updateSectionsWithPlugins({ crumbs={[ [ t`Embedding`, - "/admin/settings/embedding_in_other_applications", + "/admin/settings/embedding-in-other-applications", ], [t`Full-app embedding`], ]} @@ -464,7 +464,7 @@ const SECTIONS = updateSectionsWithPlugins({ }, { widget: () => ( - <RedirectWidget to="/admin/settings/embedding_in_other_applications" /> + <RedirectWidget to="/admin/settings/embedding-in-other-applications" /> ), getHidden: (_, derivedSettings) => derivedSettings["enable-embedding"], }, diff --git a/frontend/src/metabase/public/components/widgets/SharingPane.tsx b/frontend/src/metabase/public/components/widgets/SharingPane.tsx index 89c902ad9a8b34e67ba46eead2b243f59e4a4341..86ddf82cc567dc29319e0057b1741de5382d2d4c 100644 --- a/frontend/src/metabase/public/components/widgets/SharingPane.tsx +++ b/frontend/src/metabase/public/components/widgets/SharingPane.tsx @@ -222,7 +222,7 @@ function getEmbeddingHelperText({ return jt`In order to embed your question, you have to first ${( <a className="link" - href="/admin/settings/embedding_in_other_applications" + href="/admin/settings/embedding-in-other-applications" > enable embedding in your Admin settings. </a> diff --git a/frontend/test/metabase/scenarios/embedding/embedding-premium-token.cy.spec.js b/frontend/test/metabase/scenarios/embedding/embedding-premium-token.cy.spec.js index 2c6e176a3465306208668baed66cb2af03d3373d..f45d3591475c26a0ff456c6bdd8b7b774441711a 100644 --- a/frontend/test/metabase/scenarios/embedding/embedding-premium-token.cy.spec.js +++ b/frontend/test/metabase/scenarios/embedding/embedding-premium-token.cy.spec.js @@ -1,6 +1,6 @@ import { restore, isOSS } from "__support__/e2e/helpers"; -const embeddingPage = "/admin/settings/embedding_in_other_applications"; +const embeddingPage = "/admin/settings/embedding-in-other-applications"; const licensePage = "/admin/settings/premium-embedding-license"; // A random embedding token with valid format diff --git a/frontend/test/metabase/scenarios/embedding/embedding-smoketests.cy.spec.js b/frontend/test/metabase/scenarios/embedding/embedding-smoketests.cy.spec.js index b3d80837d7e8d8e281d15d513102e45e96e8f223..f4beeaaf564cba390ce383386f1abc1ce3cdb161 100644 --- a/frontend/test/metabase/scenarios/embedding/embedding-smoketests.cy.spec.js +++ b/frontend/test/metabase/scenarios/embedding/embedding-smoketests.cy.spec.js @@ -7,7 +7,7 @@ import { visitIframe, } from "__support__/e2e/helpers"; -const embeddingPage = "/admin/settings/embedding_in_other_applications"; +const embeddingPage = "/admin/settings/embedding-in-other-applications"; const licenseUrl = "https://metabase.com/license/embedding"; const upgradeUrl = "https://www.metabase.com/upgrade/";