From 93e7efcdd304f5da58a251b110ad5a38a4d89556 Mon Sep 17 00:00:00 2001
From: Maz Ameli <maz@metabase.com>
Date: Tue, 5 Oct 2021 12:23:20 -0700
Subject: [PATCH] Restyle the Verify button (#18134)
* restyle the Verify button
* remove unused components
* make the verify button blue
---
.../ModerationActions/ModerationActions.jsx | 13 ++++---------
.../ModerationActions/ModerationActions.styled.jsx | 6 ++----
.../view/sidebars/QuestionDetailsSidebarPanel.jsx | 2 +-
3 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/enterprise/frontend/src/metabase-enterprise/moderation/components/ModerationActions/ModerationActions.jsx b/enterprise/frontend/src/metabase-enterprise/moderation/components/ModerationActions/ModerationActions.jsx
index 8b8f69a3a10..ee9502b8530 100644
--- a/enterprise/frontend/src/metabase-enterprise/moderation/components/ModerationActions/ModerationActions.jsx
+++ b/enterprise/frontend/src/metabase-enterprise/moderation/components/ModerationActions/ModerationActions.jsx
@@ -4,8 +4,7 @@ import { t } from "ttag";
import { isItemVerified } from "metabase-enterprise/moderation/service";
-import { Container, Label, VerifyButton } from "./ModerationActions.styled";
-import Tooltip from "metabase/components/Tooltip";
+import { Container, VerifyButton } from "./ModerationActions.styled";
export default ModerationActions;
@@ -21,14 +20,10 @@ function ModerationActions({ moderationReview, className, onVerify }) {
return hasActions ? (
<Container className={className}>
- <Label>{t`Moderation`}</Label>
{!isVerified && (
- <Tooltip tooltip={t`Verify this`}>
- <VerifyButton
- data-testid="moderation-verify-action"
- onClick={onVerify}
- />
- </Tooltip>
+ <VerifyButton data-testid="moderation-verify-action" onClick={onVerify}>
+ {t`Verify this question`}
+ </VerifyButton>
)}
</Container>
) : null;
diff --git a/enterprise/frontend/src/metabase-enterprise/moderation/components/ModerationActions/ModerationActions.styled.jsx b/enterprise/frontend/src/metabase-enterprise/moderation/components/ModerationActions/ModerationActions.styled.jsx
index 453afb9d9cd..dd17fc80d11 100644
--- a/enterprise/frontend/src/metabase-enterprise/moderation/components/ModerationActions/ModerationActions.styled.jsx
+++ b/enterprise/frontend/src/metabase-enterprise/moderation/components/ModerationActions/ModerationActions.styled.jsx
@@ -29,10 +29,8 @@ export const VerifyButton = styled(Button).attrs({
iconSize: 20,
})`
border: none;
-
- &:hover {
- color: ${color(verifiedIconColor)};
- }
+ color: ${color(verifiedIconColor)};
+ padding: 8px;
&:disabled {
color: ${color("text-medium")};
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionDetailsSidebarPanel.jsx b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionDetailsSidebarPanel.jsx
index 992fc23826f..a6c6022a67a 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionDetailsSidebarPanel.jsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionDetailsSidebarPanel.jsx
@@ -38,7 +38,7 @@ function QuestionDetailsSidebarPanel({
<SidebarPaddedContent>
<QuestionActionButtons canWrite={canWrite} onOpenModal={onOpenModal} />
<ClampedDescription
- className="pb2"
+ className="pl1 pb2"
visibleLines={8}
description={description}
onEdit={onDescriptionEdit}
--
GitLab