From 947491320f6e35796c7901da6c61c3169c91f581 Mon Sep 17 00:00:00 2001
From: Gustavo Saiani <gustavo@poe.ma>
Date: Mon, 6 Jun 2022 17:32:51 +0200
Subject: [PATCH] Have filters be under titles in embedded and public pages
(#23153)
---
.../src/metabase/public/components/EmbedFrame.jsx | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/frontend/src/metabase/public/components/EmbedFrame.jsx b/frontend/src/metabase/public/components/EmbedFrame.jsx
index 16ab26c080e..7c0dbfe45b0 100644
--- a/frontend/src/metabase/public/components/EmbedFrame.jsx
+++ b/frontend/src/metabase/public/components/EmbedFrame.jsx
@@ -65,13 +65,17 @@ class EmbedFrame extends Component {
"scroll-y": innerScroll,
})}
>
- {name || (parameters && parameters.length > 0) ? (
- <div className="EmbedFrame-header flex align-center p1 sm-p2 lg-p3">
+ {name || parameters?.length > 0 ? (
+ <div className="EmbedFrame-header flex flex-column p1 sm-p2 lg-p3">
{name && (
- <TitleAndDescription title={name} description={description} />
+ <TitleAndDescription
+ title={name}
+ description={description}
+ className="my2"
+ />
)}
- {parameters && parameters.length > 0 ? (
- <div className="flex ml-auto">
+ {parameters?.length > 0 ? (
+ <div className="flex">
<SyncedParametersList
className="mt1"
dashboard={this.props.dashboard}
--
GitLab