From 9513f7e666d9ef00ff9ef20849d51f2f6128ab21 Mon Sep 17 00:00:00 2001
From: Kyle Doherty <kdoh@users.noreply.github.com>
Date: Wed, 3 May 2017 13:28:20 -0600
Subject: [PATCH] allow modal triggers to nest inside links (#4940)
---
frontend/src/metabase/components/Triggerable.jsx | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/frontend/src/metabase/components/Triggerable.jsx b/frontend/src/metabase/components/Triggerable.jsx
index b30d90daca1..703c3460cb7 100644
--- a/frontend/src/metabase/components/Triggerable.jsx
+++ b/frontend/src/metabase/components/Triggerable.jsx
@@ -109,7 +109,10 @@ export default ComposedComponent => class extends Component {
<a
id={triggerId}
ref="trigger"
- onClick={!this.props.disabled && (() => this.toggle())}
+ onClick={(event) => {
+ event.preventDefault()
+ !this.props.disabled && this.toggle()
+ }}
className={cx(triggerClasses, isOpen && triggerClassesOpen, "no-decoration", {
'cursor-default': this.props.disabled
})}
--
GitLab