From 9874df0c1314097b3f797d0774f9e28adc1a19f5 Mon Sep 17 00:00:00 2001
From: Cam Saul <cammsaul@gmail.com>
Date: Tue, 19 Feb 2019 14:47:32 -0800
Subject: [PATCH] Add :sensitive? Settings; move Settings cache logic into new
 ns

---
 src/metabase/models/setting.clj       | 2 +-
 src/metabase/models/setting/cache.clj | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/metabase/models/setting.clj b/src/metabase/models/setting.clj
index 7079d7de9e8..836f659b298 100644
--- a/src/metabase/models/setting.clj
+++ b/src/metabase/models/setting.clj
@@ -532,7 +532,7 @@
      :env_name       (env-var-name setting)
      :description    (str description)
      :default        (if set-via-env-var?
-                       (tru "Using value of env var {0}" (str \$ (env-var-name setting)))
+                       (str (tru "Using value of env var {0}" (str \$ (env-var-name setting))))
                        default)}))
 
 (defn all
diff --git a/src/metabase/models/setting/cache.clj b/src/metabase/models/setting/cache.clj
index 07de4e1faa6..35334a2ff91 100644
--- a/src/metabase/models/setting/cache.clj
+++ b/src/metabase/models/setting/cache.clj
@@ -48,7 +48,9 @@
 ;; and comparing values of `settings-last-updated`. Because the Setting table itself only stores text values, we'll
 ;; need to cast it between TEXT and TIMESTAMP SQL types as needed.
 
-(def ^String settings-last-updated-key "settings-last-updated")
+(def ^String settings-last-updated-key
+  "Internal key used to store the last updated timestamp for Settings."
+  "settings-last-updated")
 
 (defn update-settings-last-updated!
   "Update the value of `settings-last-updated` in the DB; if the row does not exist, insert one."
-- 
GitLab