From 9a38e6dbd657b7cc07e8fb278f88dc917eb2ef61 Mon Sep 17 00:00:00 2001
From: Cerberus <shadow_sun0708@hotmail.com>
Date: Thu, 19 Mar 2020 23:20:37 +0700
Subject: [PATCH] fix dimension & metrics keys possible undefined (#12046)
---
.../metabase/visualizations/components/LineAreaBarChart.jsx | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/frontend/src/metabase/visualizations/components/LineAreaBarChart.jsx b/frontend/src/metabase/visualizations/components/LineAreaBarChart.jsx
index 3ac30089836..68c9b73aae4 100644
--- a/frontend/src/metabase/visualizations/components/LineAreaBarChart.jsx
+++ b/frontend/src/metabase/visualizations/components/LineAreaBarChart.jsx
@@ -352,8 +352,10 @@ function transformSingleSeries(s, series, seriesIndex) {
const { cols, rows } = data;
const settings = getComputedSettingsForSeries([s]);
- const dimensions = settings["graph.dimensions"].filter(d => d != null);
- const metrics = settings["graph.metrics"].filter(d => d != null);
+ const dimensions = (settings["graph.dimensions"] || []).filter(
+ d => d != null,
+ );
+ const metrics = (settings["graph.metrics"] || []).filter(d => d != null);
const dimensionColumnIndexes = dimensions.map(dimensionName =>
_.findIndex(cols, col => col.name === dimensionName),
);
--
GitLab