From 9c887592be36eefebb4007961535e03d05ad8323 Mon Sep 17 00:00:00 2001
From: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Date: Fri, 16 Aug 2024 13:55:47 +0200
Subject: [PATCH] MS4: E2E sandboxing test coverage for "Link to the data
 source from notebook" project (#46903)

* Add sandboxing E2E tests

* Fix types

* Ignore TS error for now
---
 .../commands/permissions/updatePermissions.ts |  6 +-
 .../notebook-link-to-data-source.cy.spec.ts   | 78 ++++++++++++++++++-
 2 files changed, 79 insertions(+), 5 deletions(-)

diff --git a/e2e/support/commands/permissions/updatePermissions.ts b/e2e/support/commands/permissions/updatePermissions.ts
index b389d92d3fb..8f802cc12a0 100644
--- a/e2e/support/commands/permissions/updatePermissions.ts
+++ b/e2e/support/commands/permissions/updatePermissions.ts
@@ -4,7 +4,7 @@ import type {
   CollectionPermissionsGraph,
   DatabaseId,
   GroupId,
-  GroupPermissions,
+  GroupsPermissions,
   Impersonation,
   PermissionsGraph,
   SchemasPermissions,
@@ -29,7 +29,7 @@ declare global {
   namespace Cypress {
     interface Chainable {
       updatePermissionsGraph(
-        groupsPermissionsObject: GroupPermissions,
+        groupsPermissionsObject: GroupsPermissions,
         impersonations?: Impersonation[],
       ): void;
       updatePermissionsSchemas(options?: UpdatePermissionsSchemasParams): void;
@@ -57,7 +57,7 @@ const { COLLECTION_GROUP } = USER_GROUPS;
 Cypress.Commands.add(
   "updatePermissionsGraph",
   (
-    groupsPermissionsObject: GroupPermissions,
+    groupsPermissionsObject: GroupsPermissions,
     impersonations?: Impersonation[],
   ) => {
     cy.log("Fetch permissions graph");
diff --git a/e2e/test/scenarios/question/notebook-link-to-data-source.cy.spec.ts b/e2e/test/scenarios/question/notebook-link-to-data-source.cy.spec.ts
index 5e737139eac..3fba17ff5d4 100644
--- a/e2e/test/scenarios/question/notebook-link-to-data-source.cy.spec.ts
+++ b/e2e/test/scenarios/question/notebook-link-to-data-source.cy.spec.ts
@@ -2,6 +2,7 @@ import { SAMPLE_DB_ID } from "e2e/support/cypress_data";
 import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
 import {
   ADMIN_PERSONAL_COLLECTION_ID,
+  ALL_USERS_GROUP_ID,
   ORDERS_COUNT_QUESTION_ID,
   ORDERS_MODEL_ID,
 } from "e2e/support/cypress_sample_instance_data";
@@ -13,17 +14,30 @@ import {
   openReviewsTable,
   popover,
   restore,
+  setTokenFeatures,
   tableInteractive,
   visitModel,
   visitQuestion,
   visitQuestionAdhoc,
   visualize,
+  describeEE,
   type NativeQuestionDetails,
+  openProductsTable,
+  entityPickerModal,
+  entityPickerModalTab,
 } from "e2e/support/helpers";
+import { DataPermissionValue } from "metabase/admin/permissions/types";
 import { METAKEY } from "metabase/lib/browser";
 
-const { ORDERS, PRODUCTS_ID, REVIEWS, REVIEWS_ID, PEOPLE_ID, PRODUCTS } =
-  SAMPLE_DATABASE;
+const {
+  ORDERS,
+  ORDERS_ID,
+  PRODUCTS_ID,
+  REVIEWS,
+  REVIEWS_ID,
+  PEOPLE_ID,
+  PRODUCTS,
+} = SAMPLE_DATABASE;
 
 // https://docs.cypress.io/api/cypress-api/platform
 const macOSX = Cypress.platform === "darwin";
@@ -471,6 +485,66 @@ describe("scenarios > notebook > link to data source", () => {
         // cy.visit(`/question/${nestedQuestion.id}/notebook`);
       });
     });
+
+    describeEE("sandboxing", () => {
+      beforeEach(() => {
+        setTokenFeatures("all");
+
+        cy.updatePermissionsGraph({
+          [ALL_USERS_GROUP_ID]: {
+            [SAMPLE_DB_ID]: {
+              "view-data": DataPermissionValue.BLOCKED,
+            },
+          },
+        });
+
+        // @ts-expect-error - Non-trivial types in `sandboxTable` that should be addressed separately
+        cy.sandboxTable({
+          table_id: ORDERS_ID,
+          attribute_remappings: {
+            attr_uid: [
+              "dimension",
+              ["field", ORDERS.USER_ID, { "base-type": "type/Integer" }],
+            ],
+          },
+        });
+
+        cy.signInAsSandboxedUser();
+      });
+
+      it("should work for sandboxed users when opening a table/question/model", () => {
+        visitModel(ORDERS_MODEL_ID);
+        cy.findByTestId("question-row-count").should(
+          "have.text",
+          "Showing 11 rows",
+        );
+        openNotebook();
+        getNotebookStep("data").findByText("Orders Model").click(clickConfig);
+        cy.findByTestId("question-row-count").should(
+          "have.text",
+          "Showing 11 rows",
+        );
+      });
+
+      it("should work for sandboxed users when joined table is sandboxed", () => {
+        openProductsTable({ mode: "notebook" });
+        cy.findByTestId("action-buttons").button("Join data").click();
+        entityPickerModal().within(() => {
+          entityPickerModalTab("Tables").click();
+          cy.findByText("Orders").click();
+        });
+
+        getNotebookStep("join")
+          .findByLabelText("Right table")
+          .should("have.text", "Orders")
+          .click(clickConfig);
+
+        cy.findByTestId("question-row-count").should(
+          "have.text",
+          "Showing 11 rows",
+        );
+      });
+    });
   });
 
   context("joins", () => {
-- 
GitLab