From aa2afff4af30935702390779483560b7a70ad639 Mon Sep 17 00:00:00 2001
From: Gustavo Saiani <gus@metabase.com>
Date: Fri, 7 Oct 2022 10:40:40 -0300
Subject: [PATCH] Do not offer to add model to dashboard once it's created and
saved (#25828)
---
.../src/metabase/query_builder/components/QueryModals.jsx | 6 +++++-
frontend/test/metabase/scenarios/models/create.cy.spec.js | 2 --
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/frontend/src/metabase/query_builder/components/QueryModals.jsx b/frontend/src/metabase/query_builder/components/QueryModals.jsx
index 4b7a5cf5c9d..4f405513b3e 100644
--- a/frontend/src/metabase/query_builder/components/QueryModals.jsx
+++ b/frontend/src/metabase/query_builder/components/QueryModals.jsx
@@ -83,7 +83,11 @@ class QueryModals extends React.Component {
}}
onCreate={async card => {
await this.props.onCreate(card);
- onOpenModal(MODAL_TYPES.SAVED);
+ if (question.isDataset()) {
+ onCloseModal();
+ } else {
+ onOpenModal(MODAL_TYPES.SAVED);
+ }
}}
onClose={onCloseModal}
/>
diff --git a/frontend/test/metabase/scenarios/models/create.cy.spec.js b/frontend/test/metabase/scenarios/models/create.cy.spec.js
index a4b413ed839..58eb415ed21 100644
--- a/frontend/test/metabase/scenarios/models/create.cy.spec.js
+++ b/frontend/test/metabase/scenarios/models/create.cy.spec.js
@@ -22,8 +22,6 @@ describe("scenarios > models > create", () => {
cy.findByText("Save").click();
- cy.findByText("Not now").click();
-
cy.findByText("Saved");
});
});
--
GitLab