From b5f952f39ff5dad8d46530047ab5c2cdad15b9a4 Mon Sep 17 00:00:00 2001
From: "Mahatthana (Kelvin) Nomsawadi" <me@bboykelvin.dev>
Date: Tue, 23 Apr 2024 22:11:20 +0700
Subject: [PATCH] Remove unused function (#41720)
---
.../metabase-lib/v1/metadata/utils/tables.js | 43 -------------------
frontend/src/metabase/services.js | 5 ---
2 files changed, 48 deletions(-)
delete mode 100644 frontend/src/metabase-lib/v1/metadata/utils/tables.js
diff --git a/frontend/src/metabase-lib/v1/metadata/utils/tables.js b/frontend/src/metabase-lib/v1/metadata/utils/tables.js
deleted file mode 100644
index 73862c629a9..00000000000
--- a/frontend/src/metabase-lib/v1/metadata/utils/tables.js
+++ /dev/null
@@ -1,43 +0,0 @@
-import getGAMetadata from "promise-loader?global!metabase-lib/v1/metadata/utils/ga-metadata";
-
-export async function injectTableMetadata(table) {
- // HACK: inject GA metadata that we don't have intergrated on the backend yet
- if (table && table.db && table.db.engine === "googleanalytics") {
- const GA = await getGAMetadata();
- table.fields = table.fields.map(field => ({
- ...field,
- ...GA.fields[field.name],
- }));
- table.metrics.push(
- ...GA.metrics.map(metric => ({
- ...metric,
- table_id: table.id,
- googleAnalyics: true,
- })),
- );
- table.segments.push(
- ...GA.segments.map(segment => ({
- ...segment,
- table_id: table.id,
- googleAnalyics: true,
- })),
- );
- }
-
- if (table && table.fields) {
- // replace dimension_options IDs with objects
- for (const field of table.fields) {
- if (field.dimension_options) {
- field.dimension_options = field.dimension_options.map(
- id => table.dimension_options[id],
- );
- }
- if (field.default_dimension_option) {
- field.default_dimension_option =
- table.dimension_options[field.default_dimension_option];
- }
- }
- }
-
- return table;
-}
diff --git a/frontend/src/metabase/services.js b/frontend/src/metabase/services.js
index 5461e337f36..3f7ba0c3ee3 100644
--- a/frontend/src/metabase/services.js
+++ b/frontend/src/metabase/services.js
@@ -3,7 +3,6 @@ import _ from "underscore";
import api, { GET, PUT, POST, DELETE } from "metabase/lib/api";
import { IS_EMBED_PREVIEW } from "metabase/lib/embed";
import Question from "metabase-lib/v1/Question";
-import { injectTableMetadata } from "metabase-lib/v1/metadata/utils/tables";
import { normalizeParameters } from "metabase-lib/v1/parameters/utils/parameter-values";
import { isNative } from "metabase-lib/v1/queries/utils/card";
import { getPivotColumnSplit } from "metabase-lib/v1/queries/utils/pivot";
@@ -314,10 +313,6 @@ export const MetabaseApi = {
// table_fields: GET("/api/table/:tableId/fields"),
table_fks: GET("/api/table/:tableId/fks"),
// table_reorder_fields: POST("/api/table/:tableId/reorder"),
- table_query_metadata: GET(
- "/api/table/:tableId/query_metadata",
- injectTableMetadata,
- ),
tableAppendCSV: POST("/api/table/:tableId/append-csv", {
formData: true,
fetch: true,
--
GitLab