From b796e7f1d8f6abf4b55c416257b0ab4c6707826f Mon Sep 17 00:00:00 2001
From: Simon Belak <simon@metabase.com>
Date: Wed, 21 Aug 2019 23:35:07 +0100
Subject: [PATCH] Make test numerically stable (#10660)
Make insights test numerically stable
---
.../analyze/fingerprint/insights_test.clj | 81 +++++++++----------
1 file changed, 40 insertions(+), 41 deletions(-)
diff --git a/test/metabase/sync/analyze/fingerprint/insights_test.clj b/test/metabase/sync/analyze/fingerprint/insights_test.clj
index 83077efb160..856b591f5e2 100644
--- a/test/metabase/sync/analyze/fingerprint/insights_test.clj
+++ b/test/metabase/sync/analyze/fingerprint/insights_test.clj
@@ -84,48 +84,47 @@
;; Make sure we don't return nosense results like infinitiy coeficients
;; Fixes https://github.com/metabase/metabase/issues/9070
-(def ^:private ts [["2018-11-01",2960,10875]
- ["2018-11-02",2574,11762]
- ["2018-11-03",2761,13101]
- ["2018-11-04",2405,12931]
- ["2018-11-05",1726,10890]
- ["2018-11-06",1669,10829]
- ["2018-11-07",3661,10098]
- ["2018-11-08",5760,12935]
- ["2018-11-09",5251,30183]
- ["2018-11-10",5757,36148]
- ["2018-11-11",5244,32264]
- ["2018-11-12",4190,25583]
- ["2018-11-13",2343,21411]
- ["2018-11-14",2109,21848]
- ["2018-11-15",1865,19892]
- ["2018-11-16",2130,14942]
- ["2018-11-17",5037,15690]
- ["2018-11-18",5029,14506]
- ["2018-11-19",2335,10714]
- ["2018-11-20",1745,9545]
- ["2018-11-21",1784,7516]
- ["2018-11-22",1717,6460]
- ["2018-11-23",1796,4901]
- ["2018-11-24",2039,5217]
- ["2018-11-25",1781,4477]
- ["2018-11-26",1330,3263]
- ["2018-11-27",1296,2994]
- ["2018-11-28",1278,3238]
- ["2018-11-29",1377,3120]
- ["2018-11-30",1553,2984]
- ["2018-12-01",1805,3732]
- ["2018-12-02",1796,3311]
- ["2018-12-03",1444,2525]])
+(def ^:private ts [["2018-11-01",296,10875]
+ ["2018-11-02",257,11762]
+ ["2018-11-03",276,13101]
+ ["2018-11-04",240,12931]
+ ["2018-11-05",172,10890]
+ ["2018-11-06",166,10829]
+ ["2018-11-07",366,10098]
+ ["2018-11-08",576,12935]
+ ["2018-11-09",525,30183]
+ ["2018-11-10",575,36148]
+ ["2018-11-11",524,32264]
+ ["2018-11-12",419,25583]
+ ["2018-11-13",234,21411]
+ ["2018-11-14",210,21848]
+ ["2018-11-15",186,19892]
+ ["2018-11-16",213,14942]
+ ["2018-11-17",503,15690]
+ ["2018-11-18",502,14506]
+ ["2018-11-19",233,10714]
+ ["2018-11-20",174,9545]
+ ["2018-11-21",178,7516]
+ ["2018-11-22",171,6460]
+ ["2018-11-23",179,4901]
+ ["2018-11-24",203,5217]
+ ["2018-11-25",178,4477]
+ ["2018-11-26",133,3263]
+ ["2018-11-27",129,2994]
+ ["2018-11-28",127,3238]
+ ["2018-11-29",137,3120]
+ ["2018-11-30",155,2984]
+ ["2018-12-01",180,3732]
+ ["2018-12-02",179,3311]
+ ["2018-12-03",144,2525]])
-;; disabled for now
-#_(expect
- [{:last-value 1444,
- :previous-value 1796,
- :last-change -0.19599109131403117,
- :slope -73.10260695187168,
- :offset 1307680.6786987525,
- :best-fit [:+ 1307680.6786987525 [:* -73.10260695187168 :x]],
+(expect
+ [{:last-value 144,
+ :previous-value 179,
+ :last-change -0.19553072625698323,
+ :slope -7.318181818181817,
+ :offset 130909.03030303027,
+ :best-fit [:* 9.493470601414073E222 [:exp [:* -0.028454294260686058 :x]]],
:col nil}
{:last-value 2525,
:previous-value 3311,
--
GitLab