diff --git a/frontend/src/metabase/query_builder/actions/core/initializeQB.ts b/frontend/src/metabase/query_builder/actions/core/initializeQB.ts index 6ed9bd13e37154f3c53a35917ecf3bff27ffdc06..0085108ace3a139c3fe658aca98dd9966c88c63b 100644 --- a/frontend/src/metabase/query_builder/actions/core/initializeQB.ts +++ b/frontend/src/metabase/query_builder/actions/core/initializeQB.ts @@ -29,7 +29,7 @@ import { import { Card, SavedCard } from "metabase-types/types/Card"; import { getQueryBuilderModeFromLocation } from "../../typed-utils"; -import { redirectToNewQuestionFlow, updateUrl } from "../navigation"; +import { updateUrl } from "../navigation"; import { cancelQuery, runQuestionQuery } from "../querying"; import { resetQB } from "./core"; @@ -201,17 +201,6 @@ async function handleQBInit( const { options, serializedCard } = parseHash(location.hash); const hasCard = cardId || serializedCard; - if ( - !hasCard && - !options.db && - !options.table && - !options.segment && - !options.metric - ) { - dispatch(redirectToNewQuestionFlow()); - return; - } - const deserializedCard = serializedCard ? deserializeCard(serializedCard) : null; diff --git a/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts b/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts index 67518f66cfd0485d55adaa599357e4990ab04b66..e6a7f460c666ea49d5b924358b4d3e4a7ea21f82 100644 --- a/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts +++ b/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts @@ -693,12 +693,6 @@ describe("QB Actions > initializeQB", () => { }; } - it("redirects to new question flow if missing any options", async () => { - const redirectSpy = jest.spyOn(navigation, "redirectToNewQuestionFlow"); - await setupBlank(); - expect(redirectSpy).toHaveBeenCalledTimes(1); - }); - it("constructs a card based on provided 'db' param", async () => { const expectedCard = Question.create({ databaseId: SAMPLE_DATABASE?.id, diff --git a/frontend/src/metabase/query_builder/actions/navigation.js b/frontend/src/metabase/query_builder/actions/navigation.js index 73e741b48c8fa232bf033f04027bbe50fd2ef666..9ec7749a755bc974a5307577095ad78359bae6c0 100644 --- a/frontend/src/metabase/query_builder/actions/navigation.js +++ b/frontend/src/metabase/query_builder/actions/navigation.js @@ -112,14 +112,6 @@ export const locationChanged = } }; -export const REDIRECT_TO_NEW_QUESTION_FLOW = - "metabase/qb/REDIRECT_TO_NEW_QUESTION_FLOW"; - -export const redirectToNewQuestionFlow = createThunkAction( - REDIRECT_TO_NEW_QUESTION_FLOW, - () => dispatch => dispatch(replace("/question/new")), -); - export const UPDATE_URL = "metabase/qb/UPDATE_URL"; export const updateUrl = createThunkAction( UPDATE_URL,