From c595f2786e142b55b44777f9671cc7290652a8ac Mon Sep 17 00:00:00 2001
From: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Date: Wed, 16 Sep 2020 23:28:02 +0200
Subject: [PATCH] Fix failing smoketest related to admin's ability to manage
sub-collections (#13256)
---
.../metabase-smoketest/admin_setup.cy.spec.js | 41 +++++++++++--------
1 file changed, 23 insertions(+), 18 deletions(-)
diff --git a/frontend/test/metabase-smoketest/admin_setup.cy.spec.js b/frontend/test/metabase-smoketest/admin_setup.cy.spec.js
index cc02900d360..2fc54d048d9 100644
--- a/frontend/test/metabase-smoketest/admin_setup.cy.spec.js
+++ b/frontend/test/metabase-smoketest/admin_setup.cy.spec.js
@@ -1,11 +1,12 @@
import {
+ popover,
restore,
+ setupLocalHostEmail,
+ signIn,
signInAsAdmin,
- USERS,
- signOut,
signInAsNormalUser,
- signIn,
- setupLocalHostEmail,
+ signOut,
+ USERS,
} from "__support__/cypress";
const new_user = {
@@ -685,37 +686,41 @@ describe("smoketest > admin_setup", () => {
});
it("should add sub-collection and change its permissions as admin", () => {
- // Adds sub-collection
+ const subCollectionName = "test sub-collection";
signOut();
signInAsAdmin();
+
cy.visit("/collection/root");
cy.findByText("Our analytics");
cy.findByText("New collection").click();
- cy.findByLabelText("Name").type("test sub-collection");
- cy.findByLabelText("Description")
- .wait(1)
- .type("very descriptive of test sub-collection");
- cy.get(".Icon-chevrondown").click();
- cy.findAllByText("Our analytics")
- .last()
- .click();
- cy.findByText("Create").click();
+ cy.get(".Modal").within(() => {
+ cy.findByLabelText("Name").type(subCollectionName);
+ cy.findByLabelText("Description")
+ .wait(1)
+ .type(`Very nice description for ${subCollectionName}`);
- cy.get(".Icon-all");
+ cy.get(".Icon-chevrondown").click();
+ });
- // Changes permissions of sub-collection
+ popover().within(() => {
+ cy.findAllByText("Our analytics")
+ .last()
+ .click();
+ });
+ cy.findByText("Create").click();
- cy.findByText("test sub-collection").click();
+ // Changes permissions of sub-collection
+ cy.findByText(subCollectionName).click();
cy.findByText("This collection is empty, like a blank canvas");
cy.get(".Icon-lock").click();
- cy.findByText("Permissions for this collection");
+ cy.findByText(`Permissions for ${subCollectionName}`);
// Collection can no longer access sub-collection
cy.wait(1)
--
GitLab