From d00e739f18044b1f061676612ea6a5bbc7d76675 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Atte=20Kein=C3=A4nen?= <atte.keinanen@gmail.com>
Date: Thu, 1 Feb 2018 19:00:04 +0200
Subject: [PATCH] Resave the question also when updating an existing alert
---
.../src/metabase/query_builder/components/AlertModals.jsx | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/frontend/src/metabase/query_builder/components/AlertModals.jsx b/frontend/src/metabase/query_builder/components/AlertModals.jsx
index 84f7eb6efec..cde53231594 100644
--- a/frontend/src/metabase/query_builder/components/AlertModals.jsx
+++ b/frontend/src/metabase/query_builder/components/AlertModals.jsx
@@ -207,7 +207,7 @@ export class AlertEducationalScreen extends Component {
isAdmin: getUserIsAdmin(state),
question: getQuestion(state),
visualizationSettings: getVisualizationSettings(state)
-}), { updateAlert, deleteAlert })
+}), { apiUpdateQuestion, updateAlert, deleteAlert })
export class UpdateAlertModalContent extends Component {
props: {
alert: any,
@@ -228,8 +228,12 @@ export class UpdateAlertModalContent extends Component {
onAlertChange = (modifiedAlert) => this.setState({ modifiedAlert })
onUpdateAlert = async () => {
- const { updateAlert, onAlertUpdated } = this.props
+ const { apiUpdateQuestion, updateAlert, onAlertUpdated } = this.props
const { modifiedAlert } = this.state
+
+ // Resave the question here (for persisting the x/y axes; see #6749)
+ await apiUpdateQuestion()
+
await updateAlert(modifiedAlert)
onAlertUpdated()
}
--
GitLab