From d145a2474733269a9799bf1d56a020ca993bf5c4 Mon Sep 17 00:00:00 2001
From: Romeo Van Snick <romeo@romeovansnick.be>
Date: Wed, 26 Jun 2024 13:09:01 +0200
Subject: [PATCH] Add reproduction for "Closing Drop-down in Join column
selector causes non-drop-down columns to disappear" (#44675)
* Add reproduction for #19894
* Use startNewQuestion
---
.../reproductions-3.cy.spec.js | 73 +++++++++++++++++++
1 file changed, 73 insertions(+)
diff --git a/e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js b/e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js
index c8fc97ae13d..8323d306a31 100644
--- a/e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js
+++ b/e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js
@@ -1081,3 +1081,76 @@ describe("issue 40399", () => {
});
});
});
+
+describe("issue 19894", () => {
+ beforeEach(() => {
+ restore();
+ cy.signInAsNormalUser();
+ });
+
+ it("should show all columns when using the join column selecter (metabase#19894)", () => {
+ createQuestion(
+ {
+ name: "Q1",
+ query: {
+ "source-table": PRODUCTS_ID,
+ aggregation: [["count"]],
+ breakout: [["field", PRODUCTS.CATEGORY, null]],
+ },
+ },
+ {
+ wrapId: true,
+ },
+ );
+
+ createQuestion({
+ name: "Q2",
+ query: {
+ "source-table": PRODUCTS_ID,
+ aggregation: [["sum", ["field", PRODUCTS.PRICE, null]]],
+ breakout: [["field", PRODUCTS.CATEGORY, null]],
+ },
+ });
+
+ createQuestion({
+ name: "Q3",
+ query: {
+ "source-table": PRODUCTS_ID,
+ aggregation: [["avg", ["field", PRODUCTS.RATING, null]]],
+ breakout: [["field", PRODUCTS.CATEGORY, null]],
+ },
+ });
+
+ startNewQuestion();
+
+ modal().findByText("Saved questions").click();
+ modal().findByText("Q1").click();
+
+ cy.button("Join data").click();
+
+ modal().findByText("Saved questions").click();
+ modal().findByText("Q2").click();
+
+ popover().findByText("Category").click();
+ popover().findByText("Category").click();
+
+ cy.button("Join data").click();
+
+ modal().findByText("Saved questions").click();
+ modal().findByText("Q3").click();
+
+ popover().findByText("Category").should("be.visible");
+ popover().findByText("Count").should("be.visible");
+
+ popover().findByText("Q1").click();
+ popover().findByText("Q2").click();
+
+ popover().findByText("Category").should("be.visible");
+ popover().findByText("Sum of Price").should("be.visible");
+
+ popover().findByText("Q1").click();
+
+ popover().findByText("Category").should("be.visible");
+ popover().findByText("Count").should("be.visible");
+ });
+});
--
GitLab