diff --git a/frontend/src/metabase/containers/AddToDashSelectDashModal.jsx b/frontend/src/metabase/containers/AddToDashSelectDashModal.jsx index 31df0ab2ccf2fd9c3e85b6e6357f92653448d64c..a900ea345e6445b44efcbde598f43ed886f9a6bf 100644 --- a/frontend/src/metabase/containers/AddToDashSelectDashModal.jsx +++ b/frontend/src/metabase/containers/AddToDashSelectDashModal.jsx @@ -45,7 +45,7 @@ export default class AddToDashSelectDashModal extends Component { addToDashboard = (dashboard: Dashboard) => { // we send the user over to the chosen dashboard in edit mode with the current card added - this.props.onChangeLocation(Urls.dashboard(dashboard.id)+"#add="+this.props.card.id); + this.props.onChangeLocation(Urls.dashboardWithAddCard(dashboard.id, this.props.card.id)); } createDashboard = async(newDashboard: Dashboard) => { diff --git a/frontend/src/metabase/lib/urls.js b/frontend/src/metabase/lib/urls.js index 9b3912b11d70daf4344fd1413c1d8be767265960..afb4f42f9b203727e1c6316e98ce8cd17783b379 100644 --- a/frontend/src/metabase/lib/urls.js +++ b/frontend/src/metabase/lib/urls.js @@ -27,6 +27,10 @@ export function dashboard(dashboardId) { return `/dashboard/${dashboardId}`; } +export function dashboardWithAddCard(dashboardId, cardId) { + return `/dashboard/${dashboardId}#add=${cardId}`; +} + export function modelToUrl(model, modelId) { switch (model) { case "card": diff --git a/frontend/test/e2e/dashboards/dashboards.utils.js b/frontend/test/e2e/dashboards/dashboards.utils.js index ab790367caad83a66024b817cc7dbcc075d39e05..f5e6a1020258bdaf018b8d2473700d367ed5baad 100644 --- a/frontend/test/e2e/dashboards/dashboards.utils.js +++ b/frontend/test/e2e/dashboards/dashboards.utils.js @@ -3,7 +3,6 @@ export const incrementDashboardCount = () => { dashboardCount += 1; } export const getLatestDashboardUrl = () => { - console.log(`/dashboard/${dashboardCount}`) return `/dashboard/${dashboardCount}` } export const getPreviousDashboardUrl = (nFromLatest) => {