From d57148114befd76448d082ffe784c5b5ab8feaef Mon Sep 17 00:00:00 2001
From: Alexander Polyankin <alexander.polyankin@metabase.com>
Date: Fri, 6 May 2022 14:54:13 +0300
Subject: [PATCH] Use a different icon for tables on the homepage (#22445)
---
frontend/src/metabase/entities/popular-items.js | 3 ++-
frontend/src/metabase/entities/recent-items.js | 3 ++-
frontend/src/metabase/entities/tables.js | 4 +++-
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/frontend/src/metabase/entities/popular-items.js b/frontend/src/metabase/entities/popular-items.js
index 6e1a5d70dd0..965b9839bfc 100644
--- a/frontend/src/metabase/entities/popular-items.js
+++ b/frontend/src/metabase/entities/popular-items.js
@@ -13,7 +13,8 @@ export const getName = item => {
export const getIcon = item => {
const entity = getEntity(item);
- return entity.objectSelectors.getIcon(item.model_object);
+ const options = { variant: "secondary" };
+ return entity.objectSelectors.getIcon(item.model_object, options);
};
const PopularItems = createEntity({
diff --git a/frontend/src/metabase/entities/recent-items.js b/frontend/src/metabase/entities/recent-items.js
index 0687a5089a2..1f16eea5f8f 100644
--- a/frontend/src/metabase/entities/recent-items.js
+++ b/frontend/src/metabase/entities/recent-items.js
@@ -13,7 +13,8 @@ export const getName = item => {
export const getIcon = item => {
const entity = getEntity(item);
- return entity.objectSelectors.getIcon(item.model_object);
+ const options = { variant: "secondary" };
+ return entity.objectSelectors.getIcon(item.model_object, options);
};
const RecentItems = createEntity({
diff --git a/frontend/src/metabase/entities/tables.js b/frontend/src/metabase/entities/tables.js
index 7bc80be368f..8d2d6c174b5 100644
--- a/frontend/src/metabase/entities/tables.js
+++ b/frontend/src/metabase/entities/tables.js
@@ -228,7 +228,9 @@ const Tables = createEntity({
objectSelectors: {
getUrl: table =>
Urls.tableRowsQuery(table.database_id, table.table_id, null),
- getIcon: table => ({ name: "table" }),
+ getIcon: (table, { variant = "primary" } = {}) => ({
+ name: variant === "primary" ? "table" : "database",
+ }),
getColor: table => color("accent2"),
},
--
GitLab