From e8526c757ee9cb1cd883543ebd8170e531a63634 Mon Sep 17 00:00:00 2001 From: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Date: Fri, 30 Sep 2022 16:11:55 +0200 Subject: [PATCH] [FE] Remove unused `underscore` imports (#25709) * Remove unused `underscore` imports from `.ts` files * Remove unused `underscore` imports from `.tsx` files * Remove unused `underscore` imports from `.jsx` files * Remove unused `underscore` imports from `.js` files --- enterprise/frontend/src/metabase-enterprise/license/index.js | 1 - frontend/src/metabase/admin/people/components/GroupDetail.jsx | 1 - .../people/components/MembershipSelect/MembershipSelect.tsx | 1 - frontend/src/metabase/admin/people/components/PeopleListRow.jsx | 1 - frontend/src/metabase/admin/people/selectors.js | 1 - .../admin/permissions/selectors/data-permissions/breadcrumbs.ts | 1 - .../permissions/selectors/data-permissions/data-sidebar.ts | 1 - .../admin/permissions/selectors/data-permissions/fields.ts | 2 -- .../permissions/selectors/data-permissions/group-sidebar.ts | 1 - .../admin/permissions/selectors/data-permissions/schemas.ts | 2 -- .../admin/permissions/selectors/data-permissions/tables.ts | 1 - .../metabase/admin/permissions/utils/graph/permissions-diff.ts | 2 -- .../components/PinnedItemCard/PinnedItemCard.stories.tsx | 2 +- .../components/DateAllOptionsWidget/DateAllOptionsWidget.tsx | 1 - frontend/src/metabase/core/components/Select/Select.stories.tsx | 1 - frontend/src/metabase/dashboard/actions/revisions.js | 2 -- .../ClickBehaviorSidebar/LinkOptions/ValuesYouCanReference.jsx | 1 - frontend/src/metabase/hoc/Favicon.jsx | 1 - frontend/src/metabase/lib/card.js | 1 - .../MainNavbar/SidebarItems/SidebarCollectionLink.tsx | 1 - frontend/src/metabase/query_builder/actions/core/core.js | 1 - .../src/metabase/query_builder/actions/core/initializeQB.ts | 1 - .../query_builder/actions/core/initializeQB.unit.spec.ts | 2 +- .../query_builder/actions/core/updateQuestion.unit.spec.ts | 2 -- frontend/src/metabase/query_builder/actions/models.js | 1 - frontend/src/metabase/query_builder/actions/native.js | 1 - frontend/src/metabase/query_builder/actions/querying.js | 1 - frontend/src/metabase/query_builder/actions/ui.js | 1 - .../metabase/query_builder/actions/visualization-settings.js | 2 -- .../DataSelector/saved-question-picker/SavedQuestionList.jsx | 1 - .../MappedFieldPicker/MappedFieldPicker.tsx | 1 - .../components/filters/pickers/DatePicker/DatePickerFooter.tsx | 1 - .../filters/pickers/DatePicker/DatePickerShortcuts.tsx | 1 - frontend/src/metabase/reducers-main.js | 1 - .../src/metabase/visualizations/components/List/ListCell.tsx | 1 - .../visualizations/components/TableSimple/TableCell.jsx | 1 - frontend/src/metabase/visualizations/lib/apply_tooltips.js | 1 - frontend/test/metabase-lib/lib/Dimension.unit.spec.js | 1 - frontend/test/metabase-visual/notebook/notebook.cy.spec.js | 1 - .../metabase/scenarios/admin/people/group-managers.cy.spec.js | 1 - .../metabase/scenarios/filters/relative-datetime.cy.spec.js | 1 - 41 files changed, 2 insertions(+), 47 deletions(-) diff --git a/enterprise/frontend/src/metabase-enterprise/license/index.js b/enterprise/frontend/src/metabase-enterprise/license/index.js index d3ab7f75252..e278555e2db 100644 --- a/enterprise/frontend/src/metabase-enterprise/license/index.js +++ b/enterprise/frontend/src/metabase-enterprise/license/index.js @@ -1,5 +1,4 @@ import { t } from "ttag"; -import _ from "underscore"; import { updateIn } from "icepick"; import { PLUGIN_ADMIN_SETTINGS_UPDATES } from "metabase/plugins"; import LicenseAndBillingSettings from "./components/LicenseAndBillingSettings"; diff --git a/frontend/src/metabase/admin/people/components/GroupDetail.jsx b/frontend/src/metabase/admin/people/components/GroupDetail.jsx index 2ed0604392f..c770dddfa63 100644 --- a/frontend/src/metabase/admin/people/components/GroupDetail.jsx +++ b/frontend/src/metabase/admin/people/components/GroupDetail.jsx @@ -2,7 +2,6 @@ import React, { useEffect, useState } from "react"; import { connect } from "react-redux"; import { t, ngettext, msgid } from "ttag"; -import _ from "underscore"; import { isAdminGroup, diff --git a/frontend/src/metabase/admin/people/components/MembershipSelect/MembershipSelect.tsx b/frontend/src/metabase/admin/people/components/MembershipSelect/MembershipSelect.tsx index b95de9bdaef..ac299012755 100644 --- a/frontend/src/metabase/admin/people/components/MembershipSelect/MembershipSelect.tsx +++ b/frontend/src/metabase/admin/people/components/MembershipSelect/MembershipSelect.tsx @@ -1,6 +1,5 @@ import React from "react"; import { t } from "ttag"; -import _ from "underscore"; import Icon from "metabase/components/Icon"; import PopoverWithTrigger from "metabase/components/PopoverWithTrigger"; diff --git a/frontend/src/metabase/admin/people/components/PeopleListRow.jsx b/frontend/src/metabase/admin/people/components/PeopleListRow.jsx index 135565bbcce..4b710f3b987 100644 --- a/frontend/src/metabase/admin/people/components/PeopleListRow.jsx +++ b/frontend/src/metabase/admin/people/components/PeopleListRow.jsx @@ -2,7 +2,6 @@ import React, { useMemo } from "react"; import { t } from "ttag"; import moment from "moment-timezone"; -import _ from "underscore"; import { color } from "metabase/lib/colors"; import { getFullName } from "metabase/lib/user"; diff --git a/frontend/src/metabase/admin/people/selectors.js b/frontend/src/metabase/admin/people/selectors.js index 75e88de6715..09ab1ac33bc 100644 --- a/frontend/src/metabase/admin/people/selectors.js +++ b/frontend/src/metabase/admin/people/selectors.js @@ -1,5 +1,4 @@ import { createSelector } from "reselect"; -import _ from "underscore"; export const getMemberships = state => state.admin.people.memberships; diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/breadcrumbs.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/breadcrumbs.ts index 5956550c2ac..36d330a264d 100644 --- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/breadcrumbs.ts +++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/breadcrumbs.ts @@ -1,4 +1,3 @@ -import _ from "underscore"; import { Group } from "metabase-types/api"; import type Metadata from "metabase-lib/lib/metadata/Metadata"; import type Schema from "metabase-lib/lib/metadata/Schema"; diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.ts index dd843cb12d4..cdf0d22de13 100644 --- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.ts +++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/data-sidebar.ts @@ -1,6 +1,5 @@ import { createSelector } from "reselect"; import { t } from "ttag"; -import _ from "underscore"; import { getMetadataWithHiddenTables } from "metabase/selectors/metadata"; diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/fields.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/fields.ts index 2ec76a43e37..ec8fcdc6476 100644 --- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/fields.ts +++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/fields.ts @@ -1,5 +1,3 @@ -import _ from "underscore"; - import { getFieldsPermission, getNativePermission, diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.ts index b48b3ba1354..15fc5f53000 100644 --- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.ts +++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.ts @@ -1,6 +1,5 @@ import { createSelector } from "reselect"; import { t } from "ttag"; -import _ from "underscore"; import { State } from "metabase-types/store"; import { Group } from "metabase-types/api"; diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/schemas.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/schemas.ts index b7ae96730be..cbfc1c09c71 100644 --- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/schemas.ts +++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/schemas.ts @@ -1,5 +1,3 @@ -import _ from "underscore"; - import { getNativePermission, getSchemasPermission, diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/tables.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/tables.ts index 0ef33b278ee..e031d46ccac 100644 --- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/tables.ts +++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/tables.ts @@ -1,4 +1,3 @@ -import _ from "underscore"; import { push } from "react-router-redux"; import { diff --git a/frontend/src/metabase/admin/permissions/utils/graph/permissions-diff.ts b/frontend/src/metabase/admin/permissions/utils/graph/permissions-diff.ts index fb6ab6a738d..11d081b16b8 100644 --- a/frontend/src/metabase/admin/permissions/utils/graph/permissions-diff.ts +++ b/frontend/src/metabase/admin/permissions/utils/graph/permissions-diff.ts @@ -1,5 +1,3 @@ -import _ from "underscore"; - import type { Group, GroupsPermissions, diff --git a/frontend/src/metabase/collections/components/PinnedItemCard/PinnedItemCard.stories.tsx b/frontend/src/metabase/collections/components/PinnedItemCard/PinnedItemCard.stories.tsx index 614432bae20..98a93ef6c73 100644 --- a/frontend/src/metabase/collections/components/PinnedItemCard/PinnedItemCard.stories.tsx +++ b/frontend/src/metabase/collections/components/PinnedItemCard/PinnedItemCard.stories.tsx @@ -1,5 +1,5 @@ import React from "react"; -import _ from "underscore"; + import { action } from "@storybook/addon-actions"; import { ComponentStory } from "@storybook/react"; import PinnedItemCard from "./PinnedItemCard"; diff --git a/frontend/src/metabase/components/DateAllOptionsWidget/DateAllOptionsWidget.tsx b/frontend/src/metabase/components/DateAllOptionsWidget/DateAllOptionsWidget.tsx index d5a1d406293..2e8e7389b6c 100644 --- a/frontend/src/metabase/components/DateAllOptionsWidget/DateAllOptionsWidget.tsx +++ b/frontend/src/metabase/components/DateAllOptionsWidget/DateAllOptionsWidget.tsx @@ -1,6 +1,5 @@ import React, { useState } from "react"; import { t } from "ttag"; -import _ from "underscore"; import cx from "classnames"; import { dateParameterValueToMBQL } from "metabase/parameters/utils/mbql"; diff --git a/frontend/src/metabase/core/components/Select/Select.stories.tsx b/frontend/src/metabase/core/components/Select/Select.stories.tsx index 68ae0a8174d..c6a5e85291e 100644 --- a/frontend/src/metabase/core/components/Select/Select.stories.tsx +++ b/frontend/src/metabase/core/components/Select/Select.stories.tsx @@ -1,5 +1,4 @@ import React from "react"; -import _ from "underscore"; import { ComponentStory } from "@storybook/react"; import { field_semantic_types } from "metabase/lib/core"; import Select from "./Select"; diff --git a/frontend/src/metabase/dashboard/actions/revisions.js b/frontend/src/metabase/dashboard/actions/revisions.js index 36f296dc9ec..c2f0c706cc9 100644 --- a/frontend/src/metabase/dashboard/actions/revisions.js +++ b/frontend/src/metabase/dashboard/actions/revisions.js @@ -1,5 +1,3 @@ -import _ from "underscore"; - import { createThunkAction } from "metabase/lib/redux"; import { fetchDashboard, fetchDashboardCardData } from "./data-fetching"; diff --git a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/ValuesYouCanReference.jsx b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/ValuesYouCanReference.jsx index 4b134ae4ddf..cf7b159a19e 100644 --- a/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/ValuesYouCanReference.jsx +++ b/frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/ValuesYouCanReference.jsx @@ -1,7 +1,6 @@ /* eslint-disable react/prop-types */ import React from "react"; import { t } from "ttag"; -import _ from "underscore"; import AccordionList from "metabase/core/components/AccordionList"; import Icon from "metabase/components/Icon"; diff --git a/frontend/src/metabase/hoc/Favicon.jsx b/frontend/src/metabase/hoc/Favicon.jsx index 578b22b9a45..472d70e197e 100644 --- a/frontend/src/metabase/hoc/Favicon.jsx +++ b/frontend/src/metabase/hoc/Favicon.jsx @@ -1,5 +1,4 @@ import React, { useEffect } from "react"; -import _ from "underscore"; import MetabaseSettings from "../lib/settings"; const DEFAULT_FAVICON = () => MetabaseSettings.get("application-favicon-url"); diff --git a/frontend/src/metabase/lib/card.js b/frontend/src/metabase/lib/card.js index 24448d39bf1..11951de7704 100644 --- a/frontend/src/metabase/lib/card.js +++ b/frontend/src/metabase/lib/card.js @@ -1,4 +1,3 @@ -import _ from "underscore"; import * as Q_DEPRECATED from "metabase/lib/query"; import Utils from "metabase/lib/utils"; diff --git a/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarCollectionLink.tsx b/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarCollectionLink.tsx index bdb2d1ea752..c4967f58053 100644 --- a/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarCollectionLink.tsx +++ b/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarCollectionLink.tsx @@ -1,5 +1,4 @@ import React, { useEffect, useCallback, useRef, KeyboardEvent } from "react"; -import _ from "underscore"; import { Collection } from "metabase-types/api"; diff --git a/frontend/src/metabase/query_builder/actions/core/core.js b/frontend/src/metabase/query_builder/actions/core/core.js index bdc9d499785..605f9575a8e 100644 --- a/frontend/src/metabase/query_builder/actions/core/core.js +++ b/frontend/src/metabase/query_builder/actions/core/core.js @@ -1,4 +1,3 @@ -import _ from "underscore"; import { createAction } from "redux-actions"; import * as MetabaseAnalytics from "metabase/lib/analytics"; diff --git a/frontend/src/metabase/query_builder/actions/core/initializeQB.ts b/frontend/src/metabase/query_builder/actions/core/initializeQB.ts index 60a2a0219b5..48959a3435a 100644 --- a/frontend/src/metabase/query_builder/actions/core/initializeQB.ts +++ b/frontend/src/metabase/query_builder/actions/core/initializeQB.ts @@ -1,4 +1,3 @@ -import _ from "underscore"; import querystring from "querystring"; import { LocationDescriptorObject } from "history"; diff --git a/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts b/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts index 9ca88e28754..5a1f9c1f81d 100644 --- a/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts +++ b/frontend/src/metabase/query_builder/actions/core/initializeQB.unit.spec.ts @@ -1,5 +1,5 @@ import { LocationDescriptorObject } from "history"; -import _ from "underscore"; + import xhrMock from "xhr-mock"; import * as CardLib from "metabase/lib/card"; diff --git a/frontend/src/metabase/query_builder/actions/core/updateQuestion.unit.spec.ts b/frontend/src/metabase/query_builder/actions/core/updateQuestion.unit.spec.ts index fb487e4cc52..fabb2fd79f2 100644 --- a/frontend/src/metabase/query_builder/actions/core/updateQuestion.unit.spec.ts +++ b/frontend/src/metabase/query_builder/actions/core/updateQuestion.unit.spec.ts @@ -1,5 +1,3 @@ -import _ from "underscore"; - import { createMockDataset } from "metabase-types/api/mocks"; import { Card, StructuredDatasetQuery } from "metabase-types/types/Card"; import { ConcreteField, TemplateTag } from "metabase-types/types/Query"; diff --git a/frontend/src/metabase/query_builder/actions/models.js b/frontend/src/metabase/query_builder/actions/models.js index 123fca3903e..6c94ead82ef 100644 --- a/frontend/src/metabase/query_builder/actions/models.js +++ b/frontend/src/metabase/query_builder/actions/models.js @@ -1,5 +1,4 @@ import { createAction } from "redux-actions"; -import _ from "underscore"; import { merge } from "icepick"; import { t } from "ttag"; diff --git a/frontend/src/metabase/query_builder/actions/native.js b/frontend/src/metabase/query_builder/actions/native.js index 388308d79a3..8455609c935 100644 --- a/frontend/src/metabase/query_builder/actions/native.js +++ b/frontend/src/metabase/query_builder/actions/native.js @@ -1,4 +1,3 @@ -import _ from "underscore"; import { assoc, updateIn } from "icepick"; import { createAction } from "redux-actions"; diff --git a/frontend/src/metabase/query_builder/actions/querying.js b/frontend/src/metabase/query_builder/actions/querying.js index 6b91b2518e7..23c44a1b5ee 100644 --- a/frontend/src/metabase/query_builder/actions/querying.js +++ b/frontend/src/metabase/query_builder/actions/querying.js @@ -1,4 +1,3 @@ -import _ from "underscore"; import { t } from "ttag"; import { createAction } from "redux-actions"; diff --git a/frontend/src/metabase/query_builder/actions/ui.js b/frontend/src/metabase/query_builder/actions/ui.js index 252c413a15c..b449f478fa5 100644 --- a/frontend/src/metabase/query_builder/actions/ui.js +++ b/frontend/src/metabase/query_builder/actions/ui.js @@ -1,4 +1,3 @@ -import _ from "underscore"; import { createAction } from "redux-actions"; import * as MetabaseAnalytics from "metabase/lib/analytics"; diff --git a/frontend/src/metabase/query_builder/actions/visualization-settings.js b/frontend/src/metabase/query_builder/actions/visualization-settings.js index 184e3c9bb55..c3c66764579 100644 --- a/frontend/src/metabase/query_builder/actions/visualization-settings.js +++ b/frontend/src/metabase/query_builder/actions/visualization-settings.js @@ -1,5 +1,3 @@ -import _ from "underscore"; - import { getDatasetEditorTab, getPreviousQueryBuilderMode, diff --git a/frontend/src/metabase/query_builder/components/DataSelector/saved-question-picker/SavedQuestionList.jsx b/frontend/src/metabase/query_builder/components/DataSelector/saved-question-picker/SavedQuestionList.jsx index 064f863eb3c..354c1a067f1 100644 --- a/frontend/src/metabase/query_builder/components/DataSelector/saved-question-picker/SavedQuestionList.jsx +++ b/frontend/src/metabase/query_builder/components/DataSelector/saved-question-picker/SavedQuestionList.jsx @@ -1,7 +1,6 @@ import React from "react"; import { t } from "ttag"; import PropTypes from "prop-types"; -import _ from "underscore"; import { PLUGIN_MODERATION } from "metabase/plugins"; import Schemas from "metabase/entities/schemas"; diff --git a/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetFieldMetadataSidebar/MappedFieldPicker/MappedFieldPicker.tsx b/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetFieldMetadataSidebar/MappedFieldPicker/MappedFieldPicker.tsx index 7130616272c..f8e01fba947 100644 --- a/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetFieldMetadataSidebar/MappedFieldPicker/MappedFieldPicker.tsx +++ b/frontend/src/metabase/query_builder/components/DatasetEditor/DatasetFieldMetadataSidebar/MappedFieldPicker/MappedFieldPicker.tsx @@ -1,6 +1,5 @@ import React, { useCallback, useRef } from "react"; import { t } from "ttag"; -import _ from "underscore"; import { isVirtualCardId } from "metabase/lib/saved-questions"; import { SchemaTableAndFieldDataSelector } from "metabase/query_builder/components/DataSelector"; diff --git a/frontend/src/metabase/query_builder/components/filters/pickers/DatePicker/DatePickerFooter.tsx b/frontend/src/metabase/query_builder/components/filters/pickers/DatePicker/DatePickerFooter.tsx index 0d231ab728f..2210a7fd211 100644 --- a/frontend/src/metabase/query_builder/components/filters/pickers/DatePicker/DatePickerFooter.tsx +++ b/frontend/src/metabase/query_builder/components/filters/pickers/DatePicker/DatePickerFooter.tsx @@ -2,7 +2,6 @@ import React from "react"; import { t } from "ttag"; import moment from "moment-timezone"; -import _ from "underscore"; import Icon from "metabase/components/Icon"; import { diff --git a/frontend/src/metabase/query_builder/components/filters/pickers/DatePicker/DatePickerShortcuts.tsx b/frontend/src/metabase/query_builder/components/filters/pickers/DatePicker/DatePickerShortcuts.tsx index 9d3e9791511..d2f91025d28 100644 --- a/frontend/src/metabase/query_builder/components/filters/pickers/DatePicker/DatePickerShortcuts.tsx +++ b/frontend/src/metabase/query_builder/components/filters/pickers/DatePicker/DatePickerShortcuts.tsx @@ -1,5 +1,4 @@ import React, { useMemo } from "react"; -import _ from "underscore"; import SidebarHeader from "metabase/query_builder/components/SidebarHeader"; import { Filter as FilterExpression } from "metabase-types/types/Query"; diff --git a/frontend/src/metabase/reducers-main.js b/frontend/src/metabase/reducers-main.js index 0019e49f4b0..a5079895bdc 100644 --- a/frontend/src/metabase/reducers-main.js +++ b/frontend/src/metabase/reducers-main.js @@ -1,7 +1,6 @@ // Reducers needed for main application import { combineReducers } from "redux"; -import _ from "underscore"; import { PLUGIN_REDUCERS } from "metabase/plugins"; diff --git a/frontend/src/metabase/visualizations/components/List/ListCell.tsx b/frontend/src/metabase/visualizations/components/List/ListCell.tsx index 43ba22c936d..1d967858716 100644 --- a/frontend/src/metabase/visualizations/components/List/ListCell.tsx +++ b/frontend/src/metabase/visualizations/components/List/ListCell.tsx @@ -1,6 +1,5 @@ import React, { useMemo } from "react"; import cx from "classnames"; -import _ from "underscore"; import ExternalLink from "metabase/core/components/ExternalLink"; diff --git a/frontend/src/metabase/visualizations/components/TableSimple/TableCell.jsx b/frontend/src/metabase/visualizations/components/TableSimple/TableCell.jsx index 2c4eb74951f..4b16ccd1b61 100644 --- a/frontend/src/metabase/visualizations/components/TableSimple/TableCell.jsx +++ b/frontend/src/metabase/visualizations/components/TableSimple/TableCell.jsx @@ -1,7 +1,6 @@ /* eslint-disable react/prop-types */ import React, { useMemo } from "react"; import cx from "classnames"; -import _ from "underscore"; import ExternalLink from "metabase/core/components/ExternalLink"; diff --git a/frontend/src/metabase/visualizations/lib/apply_tooltips.js b/frontend/src/metabase/visualizations/lib/apply_tooltips.js index 00bf983395e..584391ccd9d 100644 --- a/frontend/src/metabase/visualizations/lib/apply_tooltips.js +++ b/frontend/src/metabase/visualizations/lib/apply_tooltips.js @@ -3,7 +3,6 @@ import d3 from "d3"; import moment from "moment-timezone"; import { getIn } from "icepick"; -import _ from "underscore"; import { formatValue } from "metabase/lib/formatting"; diff --git a/frontend/test/metabase-lib/lib/Dimension.unit.spec.js b/frontend/test/metabase-lib/lib/Dimension.unit.spec.js index 92eacdee641..88272fd527a 100644 --- a/frontend/test/metabase-lib/lib/Dimension.unit.spec.js +++ b/frontend/test/metabase-lib/lib/Dimension.unit.spec.js @@ -1,4 +1,3 @@ -import _ from "underscore"; import { metadata, ORDERS, diff --git a/frontend/test/metabase-visual/notebook/notebook.cy.spec.js b/frontend/test/metabase-visual/notebook/notebook.cy.spec.js index 4cc230de684..e5f39dea581 100644 --- a/frontend/test/metabase-visual/notebook/notebook.cy.spec.js +++ b/frontend/test/metabase-visual/notebook/notebook.cy.spec.js @@ -1,4 +1,3 @@ -import _ from "underscore"; import { restore, popover, startNewQuestion } from "__support__/e2e/helpers"; describe("visual tests > notebook > major UI elements", () => { diff --git a/frontend/test/metabase/scenarios/admin/people/group-managers.cy.spec.js b/frontend/test/metabase/scenarios/admin/people/group-managers.cy.spec.js index bbbb84fc5ab..3538e3b6215 100644 --- a/frontend/test/metabase/scenarios/admin/people/group-managers.cy.spec.js +++ b/frontend/test/metabase/scenarios/admin/people/group-managers.cy.spec.js @@ -1,4 +1,3 @@ -import _ from "underscore"; import { restore, modal, diff --git a/frontend/test/metabase/scenarios/filters/relative-datetime.cy.spec.js b/frontend/test/metabase/scenarios/filters/relative-datetime.cy.spec.js index 75301a4a8cf..bda912ca323 100644 --- a/frontend/test/metabase/scenarios/filters/relative-datetime.cy.spec.js +++ b/frontend/test/metabase/scenarios/filters/relative-datetime.cy.spec.js @@ -1,5 +1,4 @@ import moment from "moment-timezone"; -import _ from "underscore"; import { restore, popover, openOrdersTable } from "__support__/e2e/helpers"; const STARTING_FROM_UNITS = [ -- GitLab