From e91fa832d800a8a5f67cbcb2252cc448ee2a26e0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cam=20Sa=C3=BCl?= <cammsaul@gmail.com>
Date: Wed, 20 Jan 2016 21:49:31 -0800
Subject: [PATCH] New script to check for reflection warnings :unamused:
---
bin/reflection-linter | 4 ++--
src/metabase/driver/mongo.clj | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/bin/reflection-linter b/bin/reflection-linter
index e8b8f9ea834..5de9aad925c 100755
--- a/bin/reflection-linter
+++ b/bin/reflection-linter
@@ -3,9 +3,9 @@
warnings=`lein check 2>&1 | grep Reflection | grep metabase`
if [ ! -z "$warnings" ]; then
- echo -e "\e[4;31mYour code has cased introduced some reflection warnings.\e[0m 😞"
+ echo -e "\e[1;31mYour code has cased introduced some reflection warnings.\e[0m 😞"
echo "$warnings";
exit -1;
fi
-echo "\e[1;32mNo reflection warnings! Success.\e[0m"
+echo -e "\e[1;32mNo reflection warnings! Success.\e[0m"
diff --git a/src/metabase/driver/mongo.clj b/src/metabase/driver/mongo.clj
index cb0df6d7a9d..29b640db8a5 100644
--- a/src/metabase/driver/mongo.clj
+++ b/src/metabase/driver/mongo.clj
@@ -86,7 +86,7 @@
(-> field-def
(update :count safe-inc)
(update :len #(if (string? field-value)
- (+ (or % 0) (.length field-value))
+ (+ (or % 0) (count field-value))
%))
(update :types (fn [types]
(update types (type field-value) safe-inc)))
--
GitLab