From ecbc97a8ab99391ad1985ca3916861815ca175d8 Mon Sep 17 00:00:00 2001
From: Alexander Polyankin <alexander.polyankin@metabase.com>
Date: Thu, 13 Oct 2022 14:26:51 +0300
Subject: [PATCH] Remove metabase/lib/string dependency in metabase-lib
(#25907)
---
frontend/src/metabase-lib/lib/queries/NativeQuery.ts | 3 +--
frontend/src/metabase/lib/string.js | 2 --
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/frontend/src/metabase-lib/lib/queries/NativeQuery.ts b/frontend/src/metabase-lib/lib/queries/NativeQuery.ts
index 5c21a1ee4aa..bcc24093b60 100644
--- a/frontend/src/metabase-lib/lib/queries/NativeQuery.ts
+++ b/frontend/src/metabase-lib/lib/queries/NativeQuery.ts
@@ -4,7 +4,6 @@ import { t } from "ttag";
import { assoc, assocIn, chain, getIn, updateIn } from "icepick";
import _ from "underscore";
import slugg from "slugg";
-import { countLines } from "metabase/lib/string";
import { humanize } from "metabase/lib/formatting";
import Utils from "metabase/lib/utils";
import {
@@ -326,7 +325,7 @@ export default class NativeQuery extends AtomicQuery {
lineCount(): number {
const queryText = this.queryText();
- return queryText ? countLines(queryText) : 0;
+ return queryText ? queryText.split(/\n/g).length : 0;
}
/**
diff --git a/frontend/src/metabase/lib/string.js b/frontend/src/metabase/lib/string.js
index d6b6fe78fe3..2e335ae1fbe 100644
--- a/frontend/src/metabase/lib/string.js
+++ b/frontend/src/metabase/lib/string.js
@@ -14,8 +14,6 @@ export function regexpEscape(s) {
return s.replace(regexpSpecialChars, "\\$&");
}
-export const countLines = str => str.split(/\n/g).length;
-
export function caseInsensitiveSearch(haystack, needle) {
return (
!needle ||
--
GitLab