From f015f73a47424c77244446dd18786029d66f52c0 Mon Sep 17 00:00:00 2001
From: Tom Robinson <tlrobinson@gmail.com>
Date: Fri, 7 Oct 2016 10:18:13 -0700
Subject: [PATCH] =?UTF-8?q?Fix=20some=20errors=20due=20to=20newer=20versio?=
=?UTF-8?q?n=20of=20babel.=20Make=20sure=20webpack=20exits=20with=20non-ze?=
=?UTF-8?q?ro=20exit=20code=20if=20build=20fails=20=E0=B2=A0=5F=E0=B2=A0.?=
=?UTF-8?q?=20[ci=20all]?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
bin/build | 4 ++--
frontend/src/metabase/dashboard/components/RefreshWidget.jsx | 2 --
.../components/settings/ChartSettingInputNumeric.jsx | 2 --
package.json | 2 +-
4 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/bin/build b/bin/build
index 43874000a9f..e1faf0d79c0 100755
--- a/bin/build
+++ b/bin/build
@@ -21,12 +21,12 @@ npm-install() {
frontend() {
echo "Running 'webpack -p' to assemble and minify frontend assets..." &&
- ./node_modules/.bin/webpack -p
+ ./node_modules/.bin/webpack -p --bail
}
frontend-fast() {
echo "Running 'webpack' to assemble and minify frontend assets..." &&
- ./node_modules/.bin/webpack --devtool eval
+ ./node_modules/.bin/webpack --devtool eval --bail
}
sample-dataset() {
diff --git a/frontend/src/metabase/dashboard/components/RefreshWidget.jsx b/frontend/src/metabase/dashboard/components/RefreshWidget.jsx
index f68781b3b70..7558419887f 100644
--- a/frontend/src/metabase/dashboard/components/RefreshWidget.jsx
+++ b/frontend/src/metabase/dashboard/components/RefreshWidget.jsx
@@ -59,5 +59,3 @@ const RefreshOption = ({ name, period, selected, onClick }) =>
<span className={styles.name}>{ name.split(" ")[0] }</span>
<span className={styles.nameSuffix}> { name.split(" ")[1] }</span>
</li>
-
-export default RefreshWidget;
diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingInputNumeric.jsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingInputNumeric.jsx
index a6b58708c12..76a3dc4f57e 100644
--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingInputNumeric.jsx
+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingInputNumeric.jsx
@@ -39,5 +39,3 @@ export default class ChartSettingInputNumeric extends Component {
);
}
}
-
-export default ChartSettingInputNumeric;
diff --git a/package.json b/package.json
index 199b2c863fb..77dbb22a9a9 100644
--- a/package.json
+++ b/package.json
@@ -132,7 +132,7 @@
"test-watch": "karma start frontend/test/karma.conf.js --auto-watch --reporters nyan",
"test-e2e": "JASMINE_CONFIG_PATH=./frontend/test/e2e/support/jasmine.json jasmine",
"test-e2e-sauce": "USE_SAUCE=true npm run test-e2e",
- "build": "webpack",
+ "build": "webpack --bail",
"build-watch": "webpack --watch",
"build-hot": "NODE_ENV=hot webpack && NODE_ENV=hot webpack-dev-server",
"shrinkwrap": "npm prune && npm shrinkwrap --dev && ./bin/clean-shrinkwrap",
--
GitLab