From f1ea3c65f2421de85c547f3904476ab36078a20c Mon Sep 17 00:00:00 2001 From: github-automation-metabase <166700802+github-automation-metabase@users.noreply.github.com> Date: Tue, 13 Aug 2024 01:59:14 -0400 Subject: [PATCH] Fix the distance between "Field to map to" and "required" (#46747) (#46759) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> --- .../TagEditorParamParts/FieldMappingSelect.tsx | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/frontend/src/metabase/query_builder/components/template_tags/TagEditorParamParts/FieldMappingSelect.tsx b/frontend/src/metabase/query_builder/components/template_tags/TagEditorParamParts/FieldMappingSelect.tsx index 40501323a58..8046ea1ab19 100644 --- a/frontend/src/metabase/query_builder/components/template_tags/TagEditorParamParts/FieldMappingSelect.tsx +++ b/frontend/src/metabase/query_builder/components/template_tags/TagEditorParamParts/FieldMappingSelect.tsx @@ -2,16 +2,13 @@ import { t } from "ttag"; import Schemas from "metabase/entities/schemas"; import { SchemaTableAndFieldDataSelector } from "metabase/query_builder/components/DataSelector"; +import { Text } from "metabase/ui"; import type Database from "metabase-lib/v1/metadata/Database"; import type Field from "metabase-lib/v1/metadata/Field"; import type Table from "metabase-lib/v1/metadata/Table"; import type { FieldId, TemplateTag } from "metabase-types/api"; -import { - ContainerLabel, - ErrorSpan, - InputContainer, -} from "./TagEditorParam.styled"; +import { ContainerLabel, InputContainer } from "./TagEditorParam.styled"; export function FieldMappingSelect({ tag, @@ -36,7 +33,11 @@ export function FieldMappingSelect({ <InputContainer> <ContainerLabel> {t`Field to map to`} - {tag.dimension == null && <ErrorSpan>{t`(required)`}</ErrorSpan>} + {tag.dimension == null && ( + <Text c="error" span={true} ml="sm"> + {t`(required)`} + </Text> + )} </ContainerLabel> {(!hasSelectedDimensionField || -- GitLab