From f326f53aa6c30aff6c23db6409d0d4d37b518e9d Mon Sep 17 00:00:00 2001
From: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Date: Tue, 1 Feb 2022 02:02:28 +0100
Subject: [PATCH] Fix typing flake in models query editor test (#20086)
---
.../models/models-query-editor.cy.spec.js | 24 +++++++++----------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/frontend/test/metabase/scenarios/models/models-query-editor.cy.spec.js b/frontend/test/metabase/scenarios/models/models-query-editor.cy.spec.js
index 97c199836a8..8f403dd5664 100644
--- a/frontend/test/metabase/scenarios/models/models-query-editor.cy.spec.js
+++ b/frontend/test/metabase/scenarios/models/models-query-editor.cy.spec.js
@@ -154,35 +154,33 @@ describe("scenarios > models query editor", () => {
name: "Erroring Model",
dataset: true,
native: {
- query: "S",
+ // Let's use API to type the most of the query, but stil make it invalid
+ query: "SELECT ",
},
},
{ visitQuestion: true },
);
openDetailsSidebar();
- cy.findByText("Edit query definition").click();
+ cy.findByText("Customize metadata").click();
cy.findByText(/Syntax error in SQL/);
- cy.findByText("Metadata").click();
- cy.findByText(/Syntax error in SQL/);
+
cy.findByText("Query").click();
+ cy.findByText(/Syntax error in SQL/);
+
+ // Using `text-input` here, which is the textarea HTML element instead of the `ace_content` (div)
+ cy.get(".ace_text-input").type("1");
- cy.get(".ace_content").type("{backspace}SELECT * FROM ORDERS");
runNativeQuery();
- cy.get(".TableInteractive").within(() => {
- cy.findByText("TAX");
- cy.findByText("TOTAL");
- });
+
+ cy.get(".cellData").contains(1);
cy.findByText(/Syntax error in SQL/).should("not.exist");
cy.button("Save changes").click();
cy.wait("@updateCard");
- cy.get(".TableInteractive").within(() => {
- cy.findByText("TAX");
- cy.findByText("TOTAL");
- });
+ cy.get(".cellData").contains(1);
cy.findByText(/Syntax error in SQL/).should("not.exist");
});
});
--
GitLab