From f3a9d26202403f43f24e7c08d55ab3b283f71382 Mon Sep 17 00:00:00 2001 From: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Date: Thu, 27 Jun 2024 18:56:04 +0200 Subject: [PATCH] Unskip repro for #14957: Saving a question before query has been executed can be slow with UI "hanging" (#44825) --- .../question-reproductions/reproductions-1.cy.spec.js | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/e2e/test/scenarios/question-reproductions/reproductions-1.cy.spec.js b/e2e/test/scenarios/question-reproductions/reproductions-1.cy.spec.js index 9d99e6c87a1..66ec52cbc70 100644 --- a/e2e/test/scenarios/question-reproductions/reproductions-1.cy.spec.js +++ b/e2e/test/scenarios/question-reproductions/reproductions-1.cy.spec.js @@ -312,9 +312,9 @@ describe("postgres > user > query", { tags: "@external" }, () => { }); }); -const PG_DB_NAME = "QA Postgres12"; +describe("issue 14957", { tags: "@external" }, () => { + const PG_DB_NAME = "QA Postgres12"; -describe.skip("issue 14957", { tags: "@external" }, () => { beforeEach(() => { restore("postgres-12"); cy.signInAsAdmin(); @@ -323,12 +323,7 @@ describe.skip("issue 14957", { tags: "@external" }, () => { it("should save a question before query has been executed (metabase#14957)", () => { openNativeEditor({ databaseName: PG_DB_NAME }).type("select pg_sleep(60)"); - // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage - cy.findByText("Save").click(); - - cy.findByLabelText("Name").type("14957"); - cy.button("Save").click(); - + saveQuestion("14957"); modal().should("not.exist"); }); }); -- GitLab