diff --git a/frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx b/frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx index 181578a36e4405cad6842d627e4367b20a90032c..15a314cf8fb8509c939ac2db4fc618d5dd629408 100644 --- a/frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx +++ b/frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx @@ -255,16 +255,18 @@ export default class ExpressionEditorTextfield extends React.Component { this.setState({ errorMessage }); // whenever our input blurs we push the updated expression to our parent if valid - const expression = this.compileExpression(); - if (expression) { - if (!isExpression(expression)) { - console.warn("isExpression=false", expression); - } - this.props.onChange(expression); - } else if (errorMessage) { + if (errorMessage) { this.props.onError(errorMessage); } else { - this.props.onError({ message: t`Invalid expression` }); + const expression = this.compileExpression(); + if (expression) { + if (!isExpression(expression)) { + console.warn("isExpression=false", expression); + } + this.props.onChange(expression); + } else { + this.props.onError({ message: t`Invalid expression` }); + } } };