From f4fc845be33c98a2120b55c72fe3c907e46a09c5 Mon Sep 17 00:00:00 2001 From: appleby <86076+appleby@users.noreply.github.com> Date: Tue, 22 Oct 2024 10:37:25 -0700 Subject: [PATCH] Do not localize c3p0 metric descriptions (#48957) Remove localization for some additional metrics that were missed in 2882692b. --- src/metabase/analytics/prometheus.clj | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/metabase/analytics/prometheus.clj b/src/metabase/analytics/prometheus.clj index f08dd42871c..844ec651d7b 100644 --- a/src/metabase/analytics/prometheus.clj +++ b/src/metabase/analytics/prometheus.clj @@ -110,19 +110,19 @@ (def ^:private label-translation {:maxPoolSize {:label "c3p0_max_pool_size" - :description (deferred-trs "C3P0 Max pool size")} + :description "C3P0 Max pool size"} :minPoolSize {:label "c3p0_min_pool_size" - :description (deferred-trs "C3P0 Minimum pool size")} + :description "C3P0 Minimum pool size"} :numConnections {:label "c3p0_num_connections" - :description (deferred-trs "C3P0 Number of connections")} + :description "C3P0 Number of connections"} :numIdleConnections {:label "c3p0_num_idle_connections" - :description (deferred-trs "C3P0 Number of idle connections")} + :description "C3P0 Number of idle connections"} :numBusyConnections {:label "c3p0_num_busy_connections" - :description (deferred-trs "C3P0 Number of busy connections")} + :description "C3P0 Number of busy connections"} :numThreadsAwaitingCheckoutDefaultUser {:label "c3p0_num_threads_awaiting_checkout_default_user" - :description (deferred-trs "C3P0 Number of threads awaiting checkout")}}) + :description "C3P0 Number of threads awaiting checkout"}}) (defn- stats->prometheus "Create an ArrayList of GaugeMetricFamily objects containing measurements from the c3p0 stats. Stats are grouped by @@ -133,7 +133,7 @@ (if-let [{gauge-label :label desc :description} (label-translation raw-label)] (let [gauge (GaugeMetricFamily. ^String gauge-label - ^String (str desc) ;; site-localized becomes string + ^String desc (List/of "database"))] (doseq [m measurements] (.addMetric gauge (List/of (:label m)) (:value m))) -- GitLab