From fc7374363127669cb1b1517bc4d3a82f343fb612 Mon Sep 17 00:00:00 2001
From: Oisin Coveney <oisin@metabase.com>
Date: Fri, 6 Sep 2024 21:24:44 -0700
Subject: [PATCH] fix(sdk): Fix entity ID logic to use the correct status
(#47748)
* Fix entity ID status
* bump ci
---------
Co-authored-by: Bryan Maass <bryan.maass@gmail.com>
---
frontend/src/metabase/api/entity-id.ts | 2 +-
.../src/metabase/lib/entity-id/hooks/use-validated-entity-id.ts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/frontend/src/metabase/api/entity-id.ts b/frontend/src/metabase/api/entity-id.ts
index 8f3aae04878..8f61fd23e8f 100644
--- a/frontend/src/metabase/api/entity-id.ts
+++ b/frontend/src/metabase/api/entity-id.ts
@@ -30,7 +30,7 @@ export type EntityType = typeof validEntityTypes[number];
type TranslateEntityIdRequest = Partial<Record<EntityType, BaseEntityId[]>>;
export type TranslateEntityIdResponseSuccess = {
- status: "success";
+ status: "ok";
id: string | number;
type: EntityType;
};
diff --git a/frontend/src/metabase/lib/entity-id/hooks/use-validated-entity-id.ts b/frontend/src/metabase/lib/entity-id/hooks/use-validated-entity-id.ts
index 736bf67fe34..09ce241d9c7 100644
--- a/frontend/src/metabase/lib/entity-id/hooks/use-validated-entity-id.ts
+++ b/frontend/src/metabase/lib/entity-id/hooks/use-validated-entity-id.ts
@@ -71,7 +71,7 @@ export const useValidatedEntityId = <
return { id: null, isLoading: false, isError: true } as const;
}
- if (entity_ids && entity_ids[id]?.status === "success") {
+ if (entity_ids && entity_ids[id]?.status === "ok") {
return {
id: entity_ids[id].id as TReturnedId,
isLoading: false,
--
GitLab