From fd98224e4d1a00eaeea978edf7dead5c16deab6e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Atte=20Kein=C3=A4nen?= <atte.keinanen@gmail.com>
Date: Tue, 2 May 2017 15:09:44 -0700
Subject: [PATCH] Typo fixes, new comments
---
frontend/src/metabase/query_builder/actions.js | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/frontend/src/metabase/query_builder/actions.js b/frontend/src/metabase/query_builder/actions.js
index 8e014bc1d33..ca6e82c6009 100644
--- a/frontend/src/metabase/query_builder/actions.js
+++ b/frontend/src/metabase/query_builder/actions.js
@@ -156,18 +156,17 @@ export const initializeQB = createThunkAction(INITIALIZE_QB, (location, params)
if (params.cardId || serializedCard) {
// existing card being loaded
try {
- // TODO: Don't load a card if a card is passed in the hash? Speeds up the page load.
-
if (params.cardId) {
card = await loadCard(params.cardId);
- // when we are loading from a card id we want an explict clone of the card we loaded which is unmodified
+ // when we are loading from a card id we want an explicit clone of the card we loaded which is unmodified
originalCard = Utils.copy(card);
}
// if we have a serialized card then unpack it and use it
if (serializedCard) {
let deserializedCard = deserializeCardFromUrl(serializedCard);
+ // the serialized card often differs from the card stored in db so merge the properties to fetched card if needed
card = card ? _.extend(card, deserializedCard) : deserializedCard;
}
--
GitLab