From ff312a056dce177151fc30ff8f6d38d3c1874b83 Mon Sep 17 00:00:00 2001
From: Pawit Pornkitprasan <pawit@metabase.com>
Date: Tue, 26 Oct 2021 21:40:02 +0700
Subject: [PATCH] Revert "VACUUM and ANALYZE after insert" (#18665)
This reverts commit c6688f5caf226c6ec5be424859fc00b93665620f.
Redshift only supports VACUUM command at a time on the whole
cluster, so running VACUUM can fail with parallel executions.
---
.../redshift/test/metabase/test/data/redshift.clj | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/modules/drivers/redshift/test/metabase/test/data/redshift.clj b/modules/drivers/redshift/test/metabase/test/data/redshift.clj
index 20df51a7d52..747e03fb50a 100644
--- a/modules/drivers/redshift/test/metabase/test/data/redshift.clj
+++ b/modules/drivers/redshift/test/metabase/test/data/redshift.clj
@@ -4,7 +4,6 @@
[metabase.driver.sql-jdbc.sync :as sql-jdbc.sync]
[metabase.test.data.interface :as tx]
[metabase.test.data.sql :as sql.tx]
- [metabase.test.data.sql-jdbc.load-data :as load-data]
[metabase.test.data.sql.ddl :as ddl]
[metabase.util :as u]))
@@ -70,15 +69,6 @@
[& args]
(apply sql.tx/drop-table-if-exists-cascade-sql args))
-(defmethod load-data/load-data! :redshift
- [driver {:keys [database-name], :as dbdef} {:keys [table-name], :as tabledef}]
- (load-data/load-data-all-at-once! driver dbdef tabledef)
- (let [table-identifier (sql.tx/qualify-and-quote :redshift database-name table-name)
- spec (sql-jdbc.conn/connection-details->spec :redshift @db-connection-details)]
- ;; VACUUM and ANALYZE after insert to improve performance (according to doc)
- (jdbc/execute! spec (str "VACUUM " table-identifier) {:transaction? false})
- (jdbc/execute! spec (str "ANALYZE " table-identifier) {:transaction? false})))
-
;;; Create + destroy the schema used for this test session
(defn execute! [format-string & args]
--
GitLab