Skip to content
Snippets Groups Projects
  • Romeo Van Snick's avatar
    0d5bc020
    Allow setting labels for filters (#44352) · 0d5bc020
    Romeo Van Snick authored
    
    * Add csv-stringify package
    
    * Split values at comma
    
    WIP: Parse values using json
    
    * Add label to ParameterValue and add ParameterValue to value config
    
    * Use custom label in FieldValuesWidget
    
    * Allow passing displayValue from outside of RemappedValue
    
    * Allow passing displayValue in ParameterFieldWidgetValue
    
    * Get custom value label in FormatterParameterValue
    
    * Allow rendering custom displayValue in FieldValuesWidget
    
    * Add custom ParameterValue types
    
    * Fix ParameterValuePicker type
    
    * Fix jest import for csv-stringify
    
    * Add missing RTKQ exports for paramters
    
    * Use direct implementation of useGetParameterValues
    
    * Fix ValueSourceModal tests
    
    * Add tests for value parsing and stringifying
    
    * Use custom label in list too
    
    * Render the custom label in a parameter value
    
    * Setup parameter mocks in embed test
    
    * Add info about splitting values with comma
    
    * Add model hint when user is using labels
    
    * Add test for cusom labels on dashboards
    
    * Handle label-value pairs in test
    
    * Test custom labels in parameter search input
    
    * Use the label to parse the value for text inputs
    
    * Fix comma's to commas
    
    Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
    
    * Use strong instead of styling link
    
    * Use getInput instead of ignoring eslint rule
    
    * Use arrow function
    
    * Add newlines between tests
    
    * Use uppercase for test value
    
    * Name value
    
    * Use getLabel and getValue helpers to avoid indexing confusion
    
    * Pull out confusing condition
    
    * Move out getLabel helper
    
    * Be more explicit about non-existent config values
    
    Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
    
    * Move setupParameterValuesEndpoints to setup
    
    * Add loading state
    
    * Do not use alert to implement info box
    
    * Fix formatting
    
    * Remove undefined from getValue signature
    
    * Use getLearnUrl
    
    * Remove dependency on column
    
    * Make custom field labels work in the absence of fields
    
    * Support custom values for non-field parameters
    
    * Add test for native question parameters
    
    * Add newline in test
    
    * Add test case for when show-metabase-links is false
    
    * Just fall back to rendering value when fetching label, or in case it failed
    
    * Add test for loading state of FormattedParameterValue
    
    * Do not fetch custom label for FormattedParameterValue
    
    * Add table with ip addresses
    
    * Add test for IPAddress filter with custom labels
    
    * Add test for custom labels on type/Quantity fields
    
    * Remove getInput helper in test
    
    * Remove unused hasCustomLabel value
    
    * Split up into common and premium tests
    
    * Make fieldValues a map for performance
    
    ---------
    
    Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
    Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
    Allow setting labels for filters (#44352)
    Romeo Van Snick authored
    
    * Add csv-stringify package
    
    * Split values at comma
    
    WIP: Parse values using json
    
    * Add label to ParameterValue and add ParameterValue to value config
    
    * Use custom label in FieldValuesWidget
    
    * Allow passing displayValue from outside of RemappedValue
    
    * Allow passing displayValue in ParameterFieldWidgetValue
    
    * Get custom value label in FormatterParameterValue
    
    * Allow rendering custom displayValue in FieldValuesWidget
    
    * Add custom ParameterValue types
    
    * Fix ParameterValuePicker type
    
    * Fix jest import for csv-stringify
    
    * Add missing RTKQ exports for paramters
    
    * Use direct implementation of useGetParameterValues
    
    * Fix ValueSourceModal tests
    
    * Add tests for value parsing and stringifying
    
    * Use custom label in list too
    
    * Render the custom label in a parameter value
    
    * Setup parameter mocks in embed test
    
    * Add info about splitting values with comma
    
    * Add model hint when user is using labels
    
    * Add test for cusom labels on dashboards
    
    * Handle label-value pairs in test
    
    * Test custom labels in parameter search input
    
    * Use the label to parse the value for text inputs
    
    * Fix comma's to commas
    
    Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
    
    * Use strong instead of styling link
    
    * Use getInput instead of ignoring eslint rule
    
    * Use arrow function
    
    * Add newlines between tests
    
    * Use uppercase for test value
    
    * Name value
    
    * Use getLabel and getValue helpers to avoid indexing confusion
    
    * Pull out confusing condition
    
    * Move out getLabel helper
    
    * Be more explicit about non-existent config values
    
    Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
    
    * Move setupParameterValuesEndpoints to setup
    
    * Add loading state
    
    * Do not use alert to implement info box
    
    * Fix formatting
    
    * Remove undefined from getValue signature
    
    * Use getLearnUrl
    
    * Remove dependency on column
    
    * Make custom field labels work in the absence of fields
    
    * Support custom values for non-field parameters
    
    * Add test for native question parameters
    
    * Add newline in test
    
    * Add test case for when show-metabase-links is false
    
    * Just fall back to rendering value when fetching label, or in case it failed
    
    * Add test for loading state of FormattedParameterValue
    
    * Do not fetch custom label for FormattedParameterValue
    
    * Add table with ip addresses
    
    * Add test for IPAddress filter with custom labels
    
    * Add test for custom labels on type/Quantity fields
    
    * Remove getInput helper in test
    
    * Remove unused hasCustomLabel value
    
    * Split up into common and premium tests
    
    * Make fieldValues a map for performance
    
    ---------
    
    Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
    Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.