Skip to content
  • Jesse Devaney's avatar
    1711c38f
    Fix: stop prompting non-admin users to configure email or slack (#32989) · 1711c38f
    Jesse Devaney authored
    * fix specific aria-label for generic sidebar
    
    * hide dashboard subscription button
    
    - when user is non-admin and email & slack are not configured
    
    * forward non-admin user to configured subscription form
    
    * fix: show pulse list after creation for non-admins
    
    - when pulse count is 0 and a new pulse is added by non-admins, it used to auto-redirect to the creation form again b/c the new pulse was not loaded before the forwarding would occur again
    
    * refactor magic strings
    
    * fix error when pulses has no length attribute
    
    * validate forwarding in subscriptions for non-admins
    
    * add remaining specs
    
    * updated tests for new subscriptions forwarding for non-admins
    
    * update tests for subscriptions forwarding for non-admins
    
    * update tests for subscriptions forwarding for non-admins
    
    * fix unit tests
    
    * update dashboard subscriptions button to exclude heading cards
    
    * [WIP] convert E2E tests to unit tests
    
    * convert subscriptions button test to unit test
    
    * restore some E2E tests
    
    * fix unit tests
    
    - new fetch request occurring in child component DashboardHeader was causing these tests to fail on the fetch request because there was no fallback
    1711c38f
    Fix: stop prompting non-admin users to configure email or slack (#32989)
    Jesse Devaney authored
    * fix specific aria-label for generic sidebar
    
    * hide dashboard subscription button
    
    - when user is non-admin and email & slack are not configured
    
    * forward non-admin user to configured subscription form
    
    * fix: show pulse list after creation for non-admins
    
    - when pulse count is 0 and a new pulse is added by non-admins, it used to auto-redirect to the creation form again b/c the new pulse was not loaded before the forwarding would occur again
    
    * refactor magic strings
    
    * fix error when pulses has no length attribute
    
    * validate forwarding in subscriptions for non-admins
    
    * add remaining specs
    
    * updated tests for new subscriptions forwarding for non-admins
    
    * update tests for subscriptions forwarding for non-admins
    
    * update tests for subscriptions forwarding for non-admins
    
    * fix unit tests
    
    * update dashboard subscriptions button to exclude heading cards
    
    * [WIP] convert E2E tests to unit tests
    
    * convert subscriptions button test to unit test
    
    * restore some E2E tests
    
    * fix unit tests
    
    - new fetch request occurring in child component DashboardHeader was causing these tests to fail on the fetch request because there was no fallback
Loading