Skip to content
Snippets Groups Projects
  • Anton Kulyk's avatar
    a0d9e138
    Cherry pick new data picker component to master (#27174) · a0d9e138
    Anton Kulyk authored
    
    * Add basic raw data picker for app scaffolding (#25997)
    
    * Show data app page ID params in editing mode (#25943)
    
    * Data apps layout updates (#25930)
    
    * play with grid sizes to make apps feel appier [ci skip]
    
    * move app nav to bar inside app
    
    * only hide other header buttons outside of edit mode
    
    * tweak overflow issue
    
    * fix header width on data apps
    
    * add control to see app contents
    
    * set data apps layout constants contextually [ci skip]
    
    * remove hardcoded value [ci skip]
    
    * extract conextual header styles [ci skip]
    
    * set max-width on paramaters for data apps [ci skip]
    
    * move data apps nav deeper, only show if not editing [ci skip]
    
    * add spacing to contents trigger, rm old code [ci skip]
    
    * rm table thing for now [ci skip]
    
    * Fixes for data app layout updates (#25962)
    
    * Reorder import
    
    * Fix type
    
    * Fix missing translation, move out URL
    
    * Remove not used import
    
    * Rework `getSelectedItems` utility for data apps
    
    * Fix selected data app page highlighting
    
    * Don't reload app navbar on page change
    
    * Change nav item links look
    
    * Remove `DataAppPageSidebarLink`
    
    * Turn nav into HTML list
    
    * Use styled components
    
    * Fix edit button covered by visualizations
    
    * Fix opening homepage
    
    * Remove redundant prop
    
    Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
    
    * First take at parameterized data app page titles (#25938)
    
    * Bring `DataAppContext` back
    
    * Pass `onFocus` and `onBlur` to `EditableText`
    
    * Export `EditableTextProps`
    
    * Add basic `DataAppPageTitle` component
    
    * Use `DataAppPageTitle`
    
    * Fix component name
    
    * Add primitive autocompletion to page title input
    
    * Add `title_template` to `DataAppNavItem` type
    
    * Tweak value management in `DataAppPageTitle`
    
    * Handle `null` values in titles more gracefully
    
    * Don't show suggestions without detail cards
    
    * Don't add whitespace when pasting a token
    
    * Don't update app's collection all the time
    
    * Add data app related selectors to dashboard selectors
    
    * Add redux state to keep title template changes
    
    * Update page title template on page save
    
    * Wire up `DataAppPageTitle` with dashboard code
    
    * Fix unit tests
    
    * Reset state on exiting editing mode
    
    * Add back button to template data picker
    
    * Add `PanePicker` UI component
    
    * Add basic `RawDataPanePicker` component
    
    * displays databases, schemas, tables
    * allows picking a database and a schema (no tables yet)
    
    * Allow picking tables
    
    Supports single-selection and multi-selection modes
    
    * Auto-select single database schema
    
    * Use `.ts` instead of `.tsx` for hook file
    
    * Style `PanePicker`
    
    * Add `onTablesChange` callback prop to data picker
    
    * Use new data picker in new app modal
    
    * Use new data picker in add data modal
    
    * Remove `DataAppDataPicker`
    
    Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
    
    * Make `DataPicker` controlled (#26018)
    
    * Add data type picker to scaffolding data picker (#26019)
    
    * Move `useSelectedTables` one level up
    
    * Extract `DataPickerSelectedItem` type
    
    * Add `type` to `DataPickerValue` type
    
    * Handle `type` in `useDataPickerValue` hook
    
    * Add data type picker step
    
    * Add back button to raw data picker
    
    * Add `CardPicker`
    
    * Tweak spacing
    
    * Move `VirtualTable` to shared picker types
    
    * Temporary disable saved questions data type
    
    * Simplify schema loading for models and questions
    
    * Remove redundant `useMemo`
    
    * Rename `RawDataPanePicker` to `RawDataPicker` (#26020)
    
    * Add safety checks to scaffolding data picker (#26023)
    
    * Pass available data types as a prop to the picker
    
    * Use nested queries settings for data types list
    
    * Offer models only if instance has at least one
    
    * Check data access
    
    * Break `DataPicker` into container and view
    
    * Make `DataPicker` cover the whole container
    
    * Add items filters API to data app scaffolding data picker (#26024)
    
    * Uncomment saved questions data type
    
    * Add data picker filters API types
    
    * Apply data type filters
    
    * Auto pick a data type when only one is available
    
    * Export data picker types
    
    * Add `DataAppScaffoldingDataPicker` component
    
    * Use `DataAppScaffoldingDataPicker`
    
    * Improve collection selection for scaffolding data picker (#26033)
    
    * Add collection ID to data picker value type
    
    * Handle collection ID in `onChange`
    
    * Handle collection ID in `CardPicker`
    
    * Automatically open root collection
    
    * Add basic search to scaffolding data picker (#26039)
    
    * Add data picker context
    
    * Add global search to data picker
    
    * Add basic search UI to new app modal
    
    * Don't use database ID in search
    
    * Scope search depending on selected data type
    
    * Expose more data picker types
    
    * Style search input
    
    * Keep filtered out data types in mind for search
    
    * Move `MIN_SEARCH_LENGTH` to constants file
    
    * Fix can't select nested collection in card picker (#26122)
    
    * Fix conflicts
    
    Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
    Cherry pick new data picker component to master (#27174)
    Anton Kulyk authored
    
    * Add basic raw data picker for app scaffolding (#25997)
    
    * Show data app page ID params in editing mode (#25943)
    
    * Data apps layout updates (#25930)
    
    * play with grid sizes to make apps feel appier [ci skip]
    
    * move app nav to bar inside app
    
    * only hide other header buttons outside of edit mode
    
    * tweak overflow issue
    
    * fix header width on data apps
    
    * add control to see app contents
    
    * set data apps layout constants contextually [ci skip]
    
    * remove hardcoded value [ci skip]
    
    * extract conextual header styles [ci skip]
    
    * set max-width on paramaters for data apps [ci skip]
    
    * move data apps nav deeper, only show if not editing [ci skip]
    
    * add spacing to contents trigger, rm old code [ci skip]
    
    * rm table thing for now [ci skip]
    
    * Fixes for data app layout updates (#25962)
    
    * Reorder import
    
    * Fix type
    
    * Fix missing translation, move out URL
    
    * Remove not used import
    
    * Rework `getSelectedItems` utility for data apps
    
    * Fix selected data app page highlighting
    
    * Don't reload app navbar on page change
    
    * Change nav item links look
    
    * Remove `DataAppPageSidebarLink`
    
    * Turn nav into HTML list
    
    * Use styled components
    
    * Fix edit button covered by visualizations
    
    * Fix opening homepage
    
    * Remove redundant prop
    
    Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
    
    * First take at parameterized data app page titles (#25938)
    
    * Bring `DataAppContext` back
    
    * Pass `onFocus` and `onBlur` to `EditableText`
    
    * Export `EditableTextProps`
    
    * Add basic `DataAppPageTitle` component
    
    * Use `DataAppPageTitle`
    
    * Fix component name
    
    * Add primitive autocompletion to page title input
    
    * Add `title_template` to `DataAppNavItem` type
    
    * Tweak value management in `DataAppPageTitle`
    
    * Handle `null` values in titles more gracefully
    
    * Don't show suggestions without detail cards
    
    * Don't add whitespace when pasting a token
    
    * Don't update app's collection all the time
    
    * Add data app related selectors to dashboard selectors
    
    * Add redux state to keep title template changes
    
    * Update page title template on page save
    
    * Wire up `DataAppPageTitle` with dashboard code
    
    * Fix unit tests
    
    * Reset state on exiting editing mode
    
    * Add back button to template data picker
    
    * Add `PanePicker` UI component
    
    * Add basic `RawDataPanePicker` component
    
    * displays databases, schemas, tables
    * allows picking a database and a schema (no tables yet)
    
    * Allow picking tables
    
    Supports single-selection and multi-selection modes
    
    * Auto-select single database schema
    
    * Use `.ts` instead of `.tsx` for hook file
    
    * Style `PanePicker`
    
    * Add `onTablesChange` callback prop to data picker
    
    * Use new data picker in new app modal
    
    * Use new data picker in add data modal
    
    * Remove `DataAppDataPicker`
    
    Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
    
    * Make `DataPicker` controlled (#26018)
    
    * Add data type picker to scaffolding data picker (#26019)
    
    * Move `useSelectedTables` one level up
    
    * Extract `DataPickerSelectedItem` type
    
    * Add `type` to `DataPickerValue` type
    
    * Handle `type` in `useDataPickerValue` hook
    
    * Add data type picker step
    
    * Add back button to raw data picker
    
    * Add `CardPicker`
    
    * Tweak spacing
    
    * Move `VirtualTable` to shared picker types
    
    * Temporary disable saved questions data type
    
    * Simplify schema loading for models and questions
    
    * Remove redundant `useMemo`
    
    * Rename `RawDataPanePicker` to `RawDataPicker` (#26020)
    
    * Add safety checks to scaffolding data picker (#26023)
    
    * Pass available data types as a prop to the picker
    
    * Use nested queries settings for data types list
    
    * Offer models only if instance has at least one
    
    * Check data access
    
    * Break `DataPicker` into container and view
    
    * Make `DataPicker` cover the whole container
    
    * Add items filters API to data app scaffolding data picker (#26024)
    
    * Uncomment saved questions data type
    
    * Add data picker filters API types
    
    * Apply data type filters
    
    * Auto pick a data type when only one is available
    
    * Export data picker types
    
    * Add `DataAppScaffoldingDataPicker` component
    
    * Use `DataAppScaffoldingDataPicker`
    
    * Improve collection selection for scaffolding data picker (#26033)
    
    * Add collection ID to data picker value type
    
    * Handle collection ID in `onChange`
    
    * Handle collection ID in `CardPicker`
    
    * Automatically open root collection
    
    * Add basic search to scaffolding data picker (#26039)
    
    * Add data picker context
    
    * Add global search to data picker
    
    * Add basic search UI to new app modal
    
    * Don't use database ID in search
    
    * Scope search depending on selected data type
    
    * Expose more data picker types
    
    * Style search input
    
    * Keep filtered out data types in mind for search
    
    * Move `MIN_SEARCH_LENGTH` to constants file
    
    * Fix can't select nested collection in card picker (#26122)
    
    * Fix conflicts
    
    Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
saved-questions.js 1.74 KiB