e2e/test/scenarios/metrics/metrics-question.cy.spec.js · b8997a1efd7019103c3d2270291e6be9cd363fcc · Engineering Digital Service / Metabase

5 months ago

Remove "Replace or save question" UI when saving and edited question from a metric (#48669) · b8997a1e

Romeo Van Snick authored 5 months ago

* Remove 'Save as new question' toggle when saving questions from editing a metrics' ad-hoc question

* Allow visitQuestion to work for metrics

* Use visitQuestion in metric test

* Add test for #48555 (showing the 'Save as new?' ui for metrics)

* Add issue info to repro

* Use visitMetric, visitModel and visitQuestion helpers in createQuestion

* Move check to make it more clear what the save ui does

* Use cy.button for Done button

* Remove unnecessary .within

* Sign in as normal user

* Add missing dataset alias

Unverified

b8997a1e

History

Remove "Replace or save question" UI when saving and edited question from a metric (#48669)

Romeo Van Snick authored 5 months ago

* Remove 'Save as new question' toggle when saving questions from editing a metrics' ad-hoc question

* Allow visitQuestion to work for metrics

* Use visitQuestion in metric test

* Add test for #48555 (showing the 'Save as new?' ui for metrics)

* Add issue info to repro

* Use visitMetric, visitModel and visitQuestion helpers in createQuestion

* Move check to make it more clear what the save ui does

* Use cy.button for Done button

* Remove unnecessary .within

* Sign in as normal user

* Add missing dataset alias

Code owners

Assign users and groups as approvers for specific file changes. Learn more.