Skip to content
  • Kamil Mielnik's avatar
    d97e6154
    [E2E] Overload the existing E2E visitQuestion helper to make it work with the alias (#39683) · d97e6154
    Kamil Mielnik authored
    * Convert commands/api/question to TS
    
    * Add missing embedding_params and collection_position attributes to Card
    
    * Type question function
    
    * Move types to the top of file
    
    * Inline throwIfNotPresent
    
    * Add types for logAction
    
    * Define StructuredQuestionDetails & NativeQuestionDetails
    
    * Add typing to commands
    
    * Return for consistency
    
    * Remove queryType argument from question
    
    * Define typing for archiveQuestion command
    
    * Format code
    
    * Define typing for createQuestion and createNativeQuestion commands
    
    * Make options optional
    
    * Remove TODO
    
    * Use arrow functions, update JSDoc
    
    * Use type for consistency
    
    * Add missing attributes in mocks
    
    * Make embedding_params non-optional
    
    * Add boilerplate for 11994 repro
    
    * Add temporary code
    
    * Improve typing
    
    * Implement test for combo chart
    
    * Simplify code
    
    * Convert updatePermissions to TS and add typing for updatePermissionsGraph
    
    * Add typing for updatePermissionsSchemas
    
    * Add typing for API responses, make updatePermissionsSchemas parameters optional
    
    * Add JSDocs
    
    * Explicitly specify types in commands
    
    * Use CardId
    
    * Fix the test
    - add missing visuzalization_settings to the pivot question
    - use "readonly" user and drop permissions manipulations
    
    * Remove TODO
    
    * Add an explanatory comment
    
    * Inline visitDashboardByAlias
    
    * Make visitQuestion accept an alias
    
    * Use new visitQuestion interface where possible
    
    * Remove somewhat duplicated comment
    d97e6154
    [E2E] Overload the existing E2E visitQuestion helper to make it work with the alias (#39683)
    Kamil Mielnik authored
    * Convert commands/api/question to TS
    
    * Add missing embedding_params and collection_position attributes to Card
    
    * Type question function
    
    * Move types to the top of file
    
    * Inline throwIfNotPresent
    
    * Add types for logAction
    
    * Define StructuredQuestionDetails & NativeQuestionDetails
    
    * Add typing to commands
    
    * Return for consistency
    
    * Remove queryType argument from question
    
    * Define typing for archiveQuestion command
    
    * Format code
    
    * Define typing for createQuestion and createNativeQuestion commands
    
    * Make options optional
    
    * Remove TODO
    
    * Use arrow functions, update JSDoc
    
    * Use type for consistency
    
    * Add missing attributes in mocks
    
    * Make embedding_params non-optional
    
    * Add boilerplate for 11994 repro
    
    * Add temporary code
    
    * Improve typing
    
    * Implement test for combo chart
    
    * Simplify code
    
    * Convert updatePermissions to TS and add typing for updatePermissionsGraph
    
    * Add typing for updatePermissionsSchemas
    
    * Add typing for API responses, make updatePermissionsSchemas parameters optional
    
    * Add JSDocs
    
    * Explicitly specify types in commands
    
    * Use CardId
    
    * Fix the test
    - add missing visuzalization_settings to the pivot question
    - use "readonly" user and drop permissions manipulations
    
    * Remove TODO
    
    * Add an explanatory comment
    
    * Inline visitDashboardByAlias
    
    * Make visitQuestion accept an alias
    
    * Use new visitQuestion interface where possible
    
    * Remove somewhat duplicated comment
Loading