Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 18, 2024
  2. Oct 10, 2024
  3. Oct 01, 2024
  4. Aug 20, 2024
  5. Jul 08, 2024
    • bryan's avatar
      Remove enable nested queries (#44447) · fdd75ffc
      bryan authored
      
      * update e2e test for command pallete to use a valid setting
      
      * remove the setting from the ui, make it always true, unless set false from env
      
      * remove enable-nested-queries from admin section on fe
      
      - fix unused oldValue -> _oldValue
      
      * tests aren't allowed to change enable-nested-queries
      
      * fix test + disallow setting nested queries from code
      
      * we cannot set enable-nested-queries
      
      - set the env var instead
      
      * add checks for the enable-nested-queries setting
      
      * make resolve-source-cards work with enable-nested-queries setting
      
      * fix recents uri interception
      
      * return enable_nested_queries setting to client
      
      * adjust fetchmock url matcher
      
      ---------
      
      Co-authored-by: default avatarNick Fitzpatrick <nickfitz.582@gmail.com>
      fdd75ffc
  6. Jun 11, 2024
    • bryan's avatar
      Make recents understand context (#43478) · 7b849da3
      bryan authored
      
      * adds the endpoint and a test
      
      * add recents endpoint, todo: tests
      
      * add post recents endpoint
      
      * return recent views for both lists, but make the endpoint work
      
      * Make recent-views context aware
      
      - pruning is context aware, only checks for the recently-inserted
        context
      - Adds endpoints:
          - POST to create selection recents,
          - GET activity/recents
            - requres context query param to be one of:
            - all, views, selections
      
      - Adds context arg to update-users-recent-views!
      - Cleans up arg schema for update-users-recent-views
      
      * impl GET api/activity/recents
      
      - return recent-selections and recent-views from
      - send context == collection from pinned card reads
      
      * update callsites of recent-views/update-users-recent-views!
      
      - to use :view param where necessary
      
      * fixes models/recent-view tests
      
      * adds more activity/recent-view tests
      
      * wip
      
      - fix whitespace linter
      
      * Fix command palette e2e test
      
      - reuse util snake-keys
      
      * updates fe to use new recents endpoints
      
      * fixes fe type issue
      
      * snake-keys -> deep-snake-keys
      
      - I've been betrayed by lsp rename
      
      * snake-keys -> deep-snake-keys
      
      - I've been betrayed by lsp rename
      
      * log selection events for created collections
      
      * mysql doesn't allow default values for TEXT types
      
      * log a recent view on data-picker selection
      
      * decouple view-log context from card-event view context
      
      * fix a doc typo
      
      * stop double logging recent-views on POST
      
      * maybe fixes some tests
      
      * some e2e fixes
      
      * fix mysterious divide by zero during score search
      
      * fix divide by zero possibilities everywhere in score-items
      
      metabase.api.activity/score-items used to throw when there weren't any
      items being scored (even though there's a `(when (seq items) ...)` check)
      
      * more test fixes
      
      * fix more e2e tests, + rename endpoint in tests
      
      * fix oopsie
      
      * fixes a few more tests
      
      * address review comments/questions
      
      * allow for a comma delimited list in qps like ?context=views,selections
      
      returns all recent view items with those contexts, most recent first
      under the `:recents` key.
      
      * refactors FE around new endpoint
      
      * fixes for unit tests
      
      * use ms/QueryVectorOf for context
      
      * fix models/recent_views tests
      
      * use multiple query params instead of comma delimited value on FE
      
      * ignore timestamp when deduping recents
      
      * review comments + test fixing
      
      * update docstring
      
      * fix api/activity_test s
      
      * actually dedupe
      
      * add test for deduping by context
      
      * e2e fix: shows up-to-date list of recently viewed items after another page is visited
      
      * e2e fix: should undo the question replace action
      
      * e2e fix: should replace a dashboard card question (metabase#36984)
      
      * e2e fix: should preselect the most recently visited dashboard
      
      * fix 6 more e2e tests
      
      * fixes fe type check and unit failure
      
      * renames unit test mocking function
      
      * fix a flaky e2e test
      
      * widen Item to accept str or kw where sensible
      
      - allow strings or keywords for moderated_status, and authority_level
      
      * simplify impl + add test
      
      * add view-log to events schema
      
      * add collection context to view log
      
      * fix the final 2 failing e2e tests
      
      * click dashboard tab when the user has can-read? on recent entities
      
      ---------
      
      Co-authored-by: default avatarSloan Sparger <sloansparger@gmail.com>
      7b849da3
  7. May 31, 2024
    • Nick Fitzpatrick's avatar
      React 18 (#41975) · ead905b1
      Nick Fitzpatrick authored
      
      * initial commit with most types sorted
      
      * admin, binning, collections, custom-column and dashboard-cards suites
      
      * Filters, Joins, Metrics, Models, Native and Native filters suites
      
      * rest of e2e specs
      
      * filters, actions, onboarding and custom column will hopfully be green?
      
      * fixing static viz, brush filtering, login redirecting, and a few other tests
      
      * types green
      
      * linter green
      
      * hopefully fixes filter tests
      
      * I don't often cry, but when I do it's because of filter-types
      
      * hopfully sorted the last test that's failing CI
      
      * PR Feedback
      
      * yarn prettier
      
      * React 18 Upgrade - Unit Tests (#41577)
      
      * fixes for most unit tests to work with react 18 + upgraded rtl to v15
      
      * fixes all unit tests locally
      
      * fixes from rebasing
      
      * linter shames me
      
      * fix flake in maps.cy.spec.js
      
      ---------
      
      Co-authored-by: default avatarSloan Sparger <sloansparger@users.noreply.github.com>
      Co-authored-by: default avatarSloan Sparger <sloansparger@gmail.com>
      ead905b1
  8. May 30, 2024
    • bryan's avatar
      CRU card events will log recent-views, and get returned through the API (#43037) · 3b2736c2
      bryan authored
      * Handles card events for CRU (not D) => recent view
      
      * add tests
      
      * avoid some errors in dev
      
      We expect recent-views/post-process to return nil occasionally (for
      permissions reasons, or more), so let's filter those out instead of
      printing a noisy unactionable warning
      
      * uncomment and fix test
      
      * fix some cypress tests + docs improvements
      
      * update more cypress tests
      
      * more cypress test updates
      
      * adding a card puts it into your recents now
      
      * fix notebook-data-source
      
      * fix notebook-data-source
      
      * fixing more e2e tests
      
      * fix command palette e2e tests
      
      * run prettier
      
      * fix style issue
      
      * update notebook-data-source tests
      
      * update homepage e2e tests
      
      * Next question is in recents, now
      
      * update command palette: skip the first pagedown, since it is a noop
      
      * check the buttons for their respective names
      
      * ensure that the model is there, and no questions are
      3b2736c2
  9. May 24, 2024
  10. May 15, 2024
  11. May 07, 2024
  12. May 02, 2024
  13. Apr 26, 2024
  14. Apr 11, 2024
    • Nick Fitzpatrick's avatar
      40895 entity path in palette (#40985) · 29ef29e9
      Nick Fitzpatrick authored
      * collection and db breadcrumbs
      
      * compact breadcrumbs
      
      * adding navigation keybindings
      
      * recent_views and search changes to always include collection or db name
      
      * removing breadcrumbs, display parent name
      
      * removing unneeded components
      
      * e2e and FE unit tests
      
      * waitFor
      
      * e2e tests for keybindings
      
      * help
      
      * be tests passing
      
      * PR feedback and type adjustments
      
      * unit test adjustment
      29ef29e9
  15. Apr 05, 2024
  16. Apr 03, 2024
    • Nick Fitzpatrick's avatar
      Command Palette UI adjustments (#40650) · 9c477a75
      Nick Fitzpatrick authored
      * Command Palette UI adjustments
      
      * move search to end of results list
      
      * ellipsis long command palette items, min icon size and showing debounced text
      
      * setting fixed width. adjusting admin result icons and text
      
      * fixing e2e test
      9c477a75
  17. Apr 02, 2024
  18. Mar 22, 2024
    • Nick Fitzpatrick's avatar
      Command palette/main (#39268) · fbcd986c
      Nick Fitzpatrick authored
      * Command Palette
      
      * small adjustments
      
      * unit tests for results
      
      * removing dupe component
      
      * removing unneeded webpack config
      
      * fix linting issue
      
      * fixing scroll behavior for settings
      
      * moving search results message, adding embedding e2e test
      
      * unit tests for palette utils
      fbcd986c
Loading