Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 24, 2023
  2. Aug 15, 2023
  3. Jun 20, 2023
  4. Jun 02, 2023
    • Maz Ameli's avatar
      New icons (#31096) · a1b09db0
      Maz Ameli authored
      
      * arrow_left
      
      * check mark
      
      * arrow_up and chevrons
      
      * add, close, contract, embed, expand, sort
      
      * change viewbox to 16
      
      * icons in +New menu, search, and sidebar toggle
      
      * info_outlined, connections or fk icon, and tweaks to x-ray suggestion icons
      
      * fix database icon
      
      * ellipsis, person, and tweak ellipsis size in collections sidebar
      
      * home, reference or book, pencil or edit, table
      
      * dashboard action icons, and remove reference to unused ClockIcon.jsx
      
      * question action icons and related component tweaks
      
      * larger icons on HomeModelCard on homepage
      
      * dashboard and add_to_dash
      
      * snippet and variables
      
      * all the chart type icons and some field type ones
      
      * mail and groups
      
      * make sidebar icons darker blue
      
      * fix add-your-data icon
      
      * filled mail icon and use it on events modal
      
      * stars
      
      * bolt and x-rays and a bunch more
      
      * granular, metric, revision history
      
      * arrows, formula, snippets
      
      * click, cloud, boolean, unpin
      
      * return, hourglass, popover
      
      * pause, ldap, burger
      
      * gear info list pin moon sum sun verified warning
      
      * fix size of row details modal icons
      
      * fix size of left nav icons
      
      * fix size on filter widgets and some selects
      
      * set default size to 16 to fix entity menu icons etc
      
      * fix pagination icons
      
      * size and color on ItemPicker
      
      * bump up database icon in /browse to 32px
      
      * /browse bolt icon size
      
      * find and remove instances of 14px size declarations
      
      * sql editor icons
      
      * sql expand/contract button alignment
      
      * collection breadcrumbs
      
      * remove two more size 14 declarations
      
      * viz selector
      
      * fix add icon in New button
      
      * fix size of ModelDetailLink
      
      * icon for question list empty state
      
      * get rid of model_framed icon
      
      * try to fix event tick icons, replace balloons with cake
      
      * standardize size of question footer actions
      
      * fix dinosaur
      
      * switch star_outline to star, and star to star_filled
      
      * fix notebook sort action
      
      * switch data picker from table2 to table
      
      * fix slack icon
      
      * restyle HomeXrayCard
      
      * fix List icon
      
      * fix sidebar toggle icon size
      
      * fix icon size in field picker popovers
      
      * fix summarize sidebar field type icons
      
      * fix summarize sidebar Add buttons
      
      * table heading sort icons
      
      * fix filter icon, resize button icons
      
      * bulk filters icons
      
      * admin datamodel icons sizing
      
      * fix datamodel metric and segment icons, and sort icon
      
      * dashboard interactivity sidebar close icon
      
      * get rid of grabber2
      
      * bookmark and question actions icon sizes
      
      * revert icon
      
      * Icons cleanup (#31147)
      
      * remove timeline event icon stroke
      
      * cleanup
      
      * add 16x16 viewbox to svgs that were missing it
      
      * add slack_colorized
      
      * correct the join_full_outer icon
      
      * timeline events, cleanup
      
      * fix broken icons
      
      * more cleanup
      
      * fix storybook
      
      * fix all types
      
      * add stories
      
      * try fixing arrow_split
      
      ---------
      
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      
      * fix specs
      
      * fix specs
      
      * remove unused icons
      
      * use constants
      
      * increase node memory allocation
      
      * bump for chromatic too
      
      * fixes
      
      * fix arrow_split icon
      
      * fix arrow_split path attributes
      
      * fix path again and fix sizing of drillthrough menu icons
      
      * more spec fixes
      
      * prettier
      
      ---------
      
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@users.noreply.github.com>
      Co-authored-by: default avatarAleksandr Lesnenko <alxnddr@gmail.com>
      Unverified
      a1b09db0
  5. May 05, 2023
    • Nick Fitzpatrick's avatar
      Save dashboards as pdf (#30200) · f32fceca
      Nick Fitzpatrick authored
      * Generate Dashboard PDFs
      
      * Moving style logic to classes rather than style sheet
      
      * removing most logic from onClone
      
      * adjusting build js heap size
      
      * moving node_options to build-release:js
      
      * removing heap stuff
      
      * set up externals
      Unverified
      f32fceca
  6. Apr 11, 2023
  7. Mar 01, 2023
    • Nemanja Glumac's avatar
      [E2E] Regroup and move all related files to the root (#28749) · f71f20e1
      Nemanja Glumac authored
      * Register new E2E path alias
      
      * Move E2E support files
      
      * Move E2E runner files
      
      * Move E2E snapshot related files
      
      * Move E2E visual regression tests
      
      * Move E2E `downloads` scenarios
      
      * Move E2E `admin` scenarios
      
      * Move E2E `auditing` scenarios
      
      * Move E2E `bining` scenarios
      
      * Move E2E `ccollections` scenarios
      
      * Move E2E `cross-version` scenarios
      
      * Move E2E `custom-column` scenarios
      
      * Move E2E `dashboard` scenarios
      
      * Move E2E `dashboard-filters` scenarios
      
      * Move E2E `dashboard` reproductions
      
      * Move E2E `embedding` scenarios
      
      * Move E2E `filters` scenarios
      
      * Move E2E `joins` scenarios
      
      * Move E2E `models` scenarios
      
      * Move E2E `native-filters` scenarios
      
      * Move E2E `native` scenarios
      
      * Move E2E `onboarding` scenarios
      
      * Move E2E `organization` scenarios
      
      * Move E2E `permissions` scenarios
      
      * Move E2E `question` scenarios
      
      * Move E2E `visualizations` scenarios
      
      * Move E2E `sharing` scenarios
      
      * Move E2E `docker-compose`
      
      * Fix commands imports
      
      * Fix helpers imports
      
      * Fix downloads reproductions imports
      
      * Fix integration imports
      
      * Move visual regression tests
      
      * Various fixes
      
      * Move `validate-e2e-files` script
      
      * Add eslint rules for E2E folder
      
      * Improve file paths
      
      * Move `cross-version` tests into scenarios
      
      * Path fixes
      
      * Register E2E alias in tsconfig
      
      * Fix failing tests after rebase
      Unverified
      f71f20e1
  8. Feb 28, 2023
  9. Feb 27, 2023
    • Braden Shepherdson's avatar
      [metabase-lib] Dev experience and CLJC infra improvements · 4580eab9
      Braden Shepherdson authored
      Dev experience:
      - CLJS now has source maps
      - Devtools extension renders CLJS data in Chrome (et al) Devtools
      - Use a debug build of CLJS in the tests
      - Fixed line numbers and breakpoints being off-by-one in Devtools
      
      CLJC infra:
      - More robust direct approach to JS<->CLJS conversions, powered by
        Malli transformers.
      - Powerful `define-getters-and-setters` macro to generate the accessors.
      4580eab9
  10. Feb 08, 2023
  11. Jan 25, 2023
  12. Dec 19, 2022
  13. Dec 08, 2022
  14. Aug 09, 2022
  15. Jul 13, 2022
  16. Jul 12, 2022
    • Alexander Kiselev's avatar
      Create HTTP Actions (#23755) · a9a1a49c
      Alexander Kiselev authored
      
      * add tailwind
      
      * fix some tailwind css classes
      
      * first pass at create HTTP actions view
      
      * editable action name
      
      * add api func with react-query
      
      * bad refactor
      
      * clean up hook and props
      
      * added description
      
      * wip params implementation
      
      * entity loader
      
      * fixed some bugs, started removing tailwind, and added uncommitted params
      
      * fix first card assumption
      
      * Add link to `/action/create` to the "New" menu
      
      * Use `"query"` action type
      
      * Temporary disable "Query" action editor tab
      
      * Properly pass HTTP action `parameters` to the BE
      
      * Wire up HTTP action execution
      
      * Fix linter warnings
      
      * bug fix for emitter id issue and added toast
      
      * fix parameter name capitalization
      
      * fix headers
      
      * stringify body
      
      * formatting
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      a9a1a49c
  17. Jul 04, 2022
  18. Jun 29, 2022
  19. May 11, 2022
  20. May 10, 2022
  21. Feb 17, 2022
  22. Jan 26, 2022
  23. Jan 04, 2022
  24. Nov 23, 2021
  25. Nov 18, 2021
  26. Nov 05, 2021
  27. Oct 07, 2021
    • Alexander Lesnenko's avatar
      add basic typescript configuration (#18284) · 8114af48
      Alexander Lesnenko authored
      
      * add basic typescript configuration
      
      * convert a tiny hook use-debounced-value to typescript
      
      * allow any for now?
      
      * update terser and static viz configs
      
      * adjust config
      
      * change extension of QuestionActivityTimeline from jsx to js to match jest config
      
      * adjust config
      
      * skip failing tests
      
      * Fix missing question method in unit tests (#18314)
      
      * review fix
      
      * fix
      
      Co-authored-by: default avatarAnton Kulyk <kuliks.anton@gmail.com>
      Unverified
      8114af48
  28. Oct 05, 2021
  29. Oct 04, 2021
    • Ariya Hidayat's avatar
      Rename NODE_ENV to WEBPACK_BUNDLE (#18087) · 3a67ddc1
      Ariya Hidayat authored
      NODE_ENV interferes with other tools (e.g. `yarn` won't pull
      devDependencies). Since what we need is only a flag indicating Webpack
      to bundle for production vs developement, invent our own env.
      
      This also solves the mystery of unable to call `yarn build` in the build
      script `bin/build-mb/src/build.clj`.
      Unverified
      3a67ddc1
  30. Aug 31, 2021
  31. Aug 10, 2021
  32. Aug 09, 2021
    • Ariya Hidayat's avatar
      Webpack prod build: exclude ESLint loader (#17371) · 7a932452
      Ariya Hidayat authored
      There's no point of processing files via ESLint loader when building
      for production. If there's any linting issue at all, it should be
      caught with a different CI run.
      
      This shave off >2 minutes from Uberjar build (front-end step).
      
      Development/hot-reload isn't affected at all.
      Unverified
      7a932452
  33. Aug 06, 2021
  34. Jul 30, 2021
    • Dalton's avatar
      Upgrade babel to 7.x.x and jest to 27.x.x (#17137) · 3a7c3987
      Dalton authored
      * Update babel dependencies to latest
      
      * Remove some old babel dependencies
      
      The dependencies in this commit include dependencies that have been
      renamed, such as babel-cli which is now @babel/cli. It also includes
      dependencies that have been replaced, such as babel-preset-stage-0 and
      its ilk, which have been replaced with @babel/preset-env.
      
      * Remove babel-register dependency
      
      This is referenced in our webpack.config.js file. I don't think we need
      Babel in our Node envionment, but I could be wrong, so leaving this as a
      separate commit.
      
      * Remove @babel/standalone and dependent code
      
      We're using @babel/standalone to support the writing of JSX in our
      internal-only ScratchApp editor. Unfortunately, this dependency is
      large--1.5mb not gzipped--and our current build does not intelligently
      split bundles, meaning our users our burdened by the size of this
      dependency whenever they must redownload the Metabase JS bundle.
      
      I'm removing it. We should still be able to write JS in the ScratchApp,
      but JSX no longer.
      
      * Add @babel/node to dev deps
      
      Needed by a cypress command
      
      * Add browserslist config
      
      Babel's preset-env dep needs this config to determine how to transform
      our JavaScript. By default I believe it ends up defaulting to
      "defaults."
      
      "defaults" is equivalent to the following rules:
      > 0.5%, last 2 versions, Firefox ESR, not dead
      
      A comma between rules represents a UNION operator.
      
      Per
      https://www.metabase.com/docs/latest/faq/general/supported-browsers.html
      
      
      we have deprecated IE 11 so I am including that explicitly in our
      browserslist.
      
      * Update babelrc plugins and presets
      
      - Replaced presets with preset-env and preset-react
      - Updated the names of some plugins, like transform-decorators-legacy,
        which is now @babel/plugin-proposal-decorators with an explicit
        "legacy: true" passed in the config.
      - Removed add-react-displayname because it is included in preset-react
      - Removed transform-builtin-extend because it is included in preset-env*
      - Removed syntax-trailing-function-commas because it is supported by
        all browsers we support
      
      * note: There is a "loose" config option for handling the extension of builtin
      classes. We may need it, but I am not sure.
      
      * Update babel cli args
      
      Replace -q with --quiet because -q no longer exists
      
      * Fix circular dep in auth.js by making it async
      
      Our app unfortunately contains MANY circular dependencies. Some, like
      this one, caused problems when the app instantiates because the
      "refreshCurrentUser" method is undefined when auth.js is initially run.
      
      While we should in the future avoid having circular deps in the first
      place, making them run async by requiring the dep and function run-time
      fixes this particular issue.
      
      * Fix circular dependency in metabase/redux/requests.js
      
      The handleActions and createAction methods imported from
      "metabase/lib/redux" are actually just methods from the "redux-actions"
      dependency... so importing those methods directly from that dep fixes
      this circular dependency problem.
      
      * Remove references to global.services and exports in metabase/services
      
      This line breaks the build. Git blame says the line is 5 years old, and
      I wouldn't expect such code to be used with how our app now requires
      deps.
      
      * Fix MBQLArrayClause problem caused by Array extension
      
      * Explicitly pass args from flatMap to function via anonymous cb
      
      I think the old Array.prototype.flatMap prototype must've had different
      args. They are now "currentValue, index, array" so when we passed it
      "enumeratePaths" as a callback, the second arg of enumeratePaths gets
      set to a number. This breaks the logic of enumeratePaths because it is a
      recursive function that depends on that second arg getting initialized
      as an empty array by default.
      
      * Remove code that spreads non-iterable value in array
      
      New Babel is stricter about handling this sort of code that doesn't
      match the JS spec. You can't spread an undefined value inside of an
      iterator.
      
      * Update jest and babel-jest to latest
      
      Updating Babel breaks our unit tests. Updating nothing causes every test
      to fail due to a Babel version mismatch. Updating only babel-jest causes
      the following error:
      
      TypeError: Jest: a transform must export a `process` function
      
      There may be a way around updating Jest, but updating it does not appear
      to be too difficult.
      
      * Set the testEnvironment to jsdom
      
      This was the default testEnvironment in our old version of jest. At some
      point the default was changed to node.
      
      * Remove unfinished "pending" unit tests
      
      I'm unfamiliar with this pending function, but the function no longer
      exists, causing the tests to fail.
      
      * don't pass async callback to describe
      
      * Update name of runTimersToTime to advanceTimersByTime
      
      * Fix incorrectly nested unit test
      
      * mock SVGElement.prototype.getBBox method
      
      * Don't return values in describe callback
      
      * Move variable declaration to above usage
      
      * Fix prettier error
      
      * Upgrade `documentation` library to the latest version (13.x.x)
      
      This library was the only one left that was still using Babel 6.
      
      * Return an MBQLClause instance after using Array methods
      
      * remove 'not IE 11' from browserslist
      
      * Remove mock that breaks unit test
      
      Co-authored-by: default avatarNemanja <31325167+nemanjaglumac@users.noreply.github.com>
      Unverified
      3a7c3987
  35. Jul 19, 2021
  36. Mar 16, 2021
  37. Mar 05, 2021
    • Cam Saul's avatar
      Shared CLJ/CLJS lib (#14980) · cca03d22
      Cam Saul authored
      * Shared CLJ/CLJS lib (PoC/WIP)
      
      * PoC 2.0
      
      * Fixes :wrench:
      
      * More test fixes :wrench:
      
      * Bump shadow-cljs version
      
      * Fix more stuff
      
      * Need to ^:export the exports
      
      * CI fixes :wrench:
      
      * Add eslintignore
      
      * Ignore cljs files for FE code coverage
      
      * Try prefixing CLJS -> JS import with goog:
      
      * Revert indentation change
      
      * No goog:
      
      * Add .prettierignore
      
      * Use advanced build for now for JS tests unit we can figure out how to make it work
      Unverified
      cca03d22
  38. Mar 01, 2021
    • Nemanja Glumac's avatar
      Upgrade React to v16 (#14391) · 28ce196d
      Nemanja Glumac authored
      
      * Upgrade React to v16
      
      * Upgrade react-hot-loader
      
      * Use portal in BodyComponent (#14779)
      
      * Use portal in Popover (#14799)
      
      * Use portal in Popover
      
      * Use SandboxedPortal to stop portal child/parent event propagation
      
      React portals bubble events from component childrent to component
      parents _through_ the portal as though they are attached. This breaks
      our Triggerable HOC that wraps everything in an anchor tag -- click
      events inside of an open Popover trigger the "toggle" function in
      Triggerable, closing the Popover component.
      
      Adding an additional div to the code potentially breaks styling, but
      this seemed better than the alternative of changing/limiting
      Triggerable.
      
      * Fix adding of open class
      
      * don't trigger some logic when popover is not open
      
      * change wrapper span to a div
      
      * rmv explicit bind from handleDismissal fn
      
      * add comment explaining reasoning for SandboxedPortal
      
      * add comment to explain need for 'maxHeight' state value
      
      * Use ReactDOMServer to render html in a contenteditable div (#14869)
      
      As part of the react v16 we can no longer rely on a synchronous
      ReactDOM.render call. Using the third arg callback of ReactDOM.render
      does not work for reasons unknown to me, but it would likely be
      race-condition-y anyways due to this being an input field. I'm using
      ReactDOMServer in order to avoid rewriting the react TokenizedExpression
      component as html and to avoid associated xss vulnerabilities, etc.
      
      * Rename unsafe lifecycles (#14887)
      
      * Rename unsafe lifecycles
      
      * Fix flow error: Remove unused suppressions
      
      * use SandboxedPortal in Modal (#14905)
      
      * use SandboxedPortal in Modal
      
      * Move modal append container to constructor
      
      This breaks the entry animation but it fixes problems with having a
      popover _inside_ of the modal. Previously, popover was appending its
      container el before the modal, causing a stacking issue.
      
      * remove unstable_renderSubtreeIntoContainer from Tooltip (#14976)
      
      Co-authored-by: default avatarDalton <daltojohnso@users.noreply.github.com>
      Unverified
      28ce196d
  39. Dec 09, 2020
    • Robert Roland's avatar
      Dashboard subscriptions work, squashed (#13390) · dd2ecc51
      Robert Roland authored
      
      * Dashboard subscriptions work, squashed
      
      This test namespace differs in EE and OSS
      
      Without other changes from EE, this won't work
      
      so, for now, I've restored the pure OSS version of this test
      
      redo wording on existing subscription cards
      
      hacks? to address some timing issues where the render loop executes
      before properties are available (loaded from the server)
      
      links to configure pulse types
      
      Display a link to configure email or slack when they aren't already
      
      Fix the am/pm picker
      
      set up a new schedule tooltip
      
      The sidebar can appear and disappear from the Sharing popover
      
      run prettier on everything
      
      email recipients now does the "name [and n other]" thing
      
      Dashboard subscriptions work, squashed
      
      redo wording on existing subscription cards
      
      hacks? to address some timing issues where the render loop executes
      before properties are available (loaded from the server)
      
      styling for email not configured state
      
      add styling for slack unconfigured state
      
      disable cursor-pointer if email or slack isn't configured
      
      Implement cancel button for the sidebar (#13741)
      
      Dashboard subscription UX enhancements:
      
      * Implement cancel button for the sidebar
      
      * Don't return duplicate dashboard subscriptions
      
      * Move sidebar cancellation into Redux
      
      * Add close icon
      
      * Fix popover behavior
      
      Dashboard Subscriptions: Fix build (#13859)
      
      * Frontend lint fixes
      
      * Fix failing email tests
      
      * Revert some of the snapshot changes
      
      * regenerate snapshots
      
      * done fixing FE tests?
      
      * Make `dashboard_card_id` optional in CardRef schema
      
      * Fix test setup in pulse model test
      
      * Fix collection API test
      
      * Order pulses by name
      
      * Cypress fixes/skips
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      
      Subscribe to dashboards send test email (#13886)
      
      * Frontend lint fixes
      
      * Fix failing email tests
      
      * Revert some of the snapshot changes
      
      * regenerate snapshots
      
      * done fixing FE tests?
      
      * Make `dashboard_card_id` optional in CardRef schema
      
      * Fix test setup in pulse model test
      
      * Fix collection API test
      
      * Order pulses by name
      
      * Cypress fixes/skips
      
      * uggh cypress
      
      * Add button to send test email for dashboard subscriptions
      
      * Disable test email with no recipients
      
      * Refactor SendTestEmail
      
      Co-authored-by: default avatarPaul Rosenzweig <paul.a.rosenzweig@gmail.com>
      
      Fix failing collection tests (#13891)
      
      * Move dashboard embedding button (#13928)
      
      * Revert migration 277 (as in master)
      
      styling and hover tweaks for subscription cards (#14003)
      
      Fix positioning of create and close buttons (#13999)
      
      * fix positioning of create and close buttons
      
      * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx
      
      * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx
      
      * import Flex
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      Co-authored-by: default avatarKyle Doherty <kyle.l.doherty@gmail.com>
      
      Add deprecation warning to Pulse create/edit page (#13954)
      
      * add pulse deprecation warning
      
      * remove unused Link component
      
      * kyle comments
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      * Update frontend/src/metabase/pulse/components/PulseEdit.jsx
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      Co-authored-by: default avatarKyle Doherty <kdoh@users.noreply.github.com>
      
      More dash subscription styling tweaks (#14006)
      
      * change hovers for email and slack delivery options
      
      * calm down, delete button
      
      * style csv and xlsx options as buttongroup
      
      * settings spacing tweaks
      
      Dashboard subscription attachment question selection (#13950)
      
      * Move email attachment into its own component
      
      Add appropriate checkbox behavior
      
      Set pulseCards appropriately
      
      * Delete PulseCards when dashboard card removed
      
      Co-authored-by: default avatarCam Saul <github@camsaul.com>
      Unverified
      dd2ecc51
  40. Oct 29, 2020
Loading