Skip to content
Snippets Groups Projects
  • Cam Saul's avatar
    a32bb77b
    Athena driver (#26301) · a32bb77b
    Cam Saul authored
    * Include Amazon Athena support for dacort/metabase-athena-driver
    
    * Use Metabase Maven repo to fetch Athena driver
    
    * Copy test extensions from Damon's Athena driver repo
    
    * Some code cleanup.
    
    * Move namespaces => metabase.driver.athena
    
    * Clean up the test extensions namespace
    
    * 42 failures, 16 errors
    
    * Fix regex support; disable a few tests
    
    * Minor tweaks
    
    * Fix data-source-name
    
    * Fix :week and :day-of-week impls (mostly): 2 failures, 3 errors
    
    * Fix OFFSET, :week-of-year; skip test that has TIME column
    
    * Add Athena to CircleCI config. Don't wait for Java 11 tests to finish before driver tests.
    
    * ALL TESTS ARE PASSING! <3
    
    * Copy fixes for https://github.com/dacort/metabase-athena-driver/issues/115;
    
     add test
    
    * We don't need to prep source files or fetch dependencies before running backend tests.
    
    * Fix Eastwood error.
    
    * Tweak CircleCI config.
    
    * Fix TIMESTAMP WITH TIME ZONE
    
    * Include the Athena/Redshift repos in the build-drivers deps.edn
    
    * Build and release scripts need to have the :mvn/repos as well
    
    * Revert change that enabled test for Presto
    
    * Un-enable failing test for Snowflake as well.
    
    * moves all is clauses into the test
    
    - previously only the first few tests were being run
    
    * Sort ns in `metabase.driver.athena-test`
    
    * Prevent athena's log4j2.properties file from becoming log config
    
    athena includes log4j2.properties top-level with the properties:
    
    ```
    status = debug
    rootLogger.level=debug
    ```
    
    And this kills our beautifully crafted logging. Set
    "log4j2.configurationFile" in bootstrap to our own log4j2.xml.
    
    Log4j2 looks in a few places for its logging config, the first of which
    is the properties file. So when the jar is loaded, log4j2 considers this
    a logging config change and we lose our logging.
    
    Co-authored-by: default avatarDamon P. Cortesi <d.lifehacker@gmail.com>
    Co-authored-by: default avatarBryan Maass <bryan.maass@gmail.com>
    Co-authored-by: default avatardan sutton <dan@dpsutton.com>
    Athena driver (#26301)
    Cam Saul authored
    * Include Amazon Athena support for dacort/metabase-athena-driver
    
    * Use Metabase Maven repo to fetch Athena driver
    
    * Copy test extensions from Damon's Athena driver repo
    
    * Some code cleanup.
    
    * Move namespaces => metabase.driver.athena
    
    * Clean up the test extensions namespace
    
    * 42 failures, 16 errors
    
    * Fix regex support; disable a few tests
    
    * Minor tweaks
    
    * Fix data-source-name
    
    * Fix :week and :day-of-week impls (mostly): 2 failures, 3 errors
    
    * Fix OFFSET, :week-of-year; skip test that has TIME column
    
    * Add Athena to CircleCI config. Don't wait for Java 11 tests to finish before driver tests.
    
    * ALL TESTS ARE PASSING! <3
    
    * Copy fixes for https://github.com/dacort/metabase-athena-driver/issues/115;
    
     add test
    
    * We don't need to prep source files or fetch dependencies before running backend tests.
    
    * Fix Eastwood error.
    
    * Tweak CircleCI config.
    
    * Fix TIMESTAMP WITH TIME ZONE
    
    * Include the Athena/Redshift repos in the build-drivers deps.edn
    
    * Build and release scripts need to have the :mvn/repos as well
    
    * Revert change that enabled test for Presto
    
    * Un-enable failing test for Snowflake as well.
    
    * moves all is clauses into the test
    
    - previously only the first few tests were being run
    
    * Sort ns in `metabase.driver.athena-test`
    
    * Prevent athena's log4j2.properties file from becoming log config
    
    athena includes log4j2.properties top-level with the properties:
    
    ```
    status = debug
    rootLogger.level=debug
    ```
    
    And this kills our beautifully crafted logging. Set
    "log4j2.configurationFile" in bootstrap to our own log4j2.xml.
    
    Log4j2 looks in a few places for its logging config, the first of which
    is the properties file. So when the jar is loaded, log4j2 considers this
    a logging config change and we lose our logging.
    
    Co-authored-by: default avatarDamon P. Cortesi <d.lifehacker@gmail.com>
    Co-authored-by: default avatarBryan Maass <bryan.maass@gmail.com>
    Co-authored-by: default avatardan sutton <dan@dpsutton.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.