Skip to content
Snippets Groups Projects
  • github-automation-metabase's avatar
    1f1c61f5
    Streamline embed flow when embedding is off (#50842) (#50979) · 1f1c61f5
    github-automation-metabase authored
    
    * Always show embed sharing option for admins (#50513)
    
    * Always render the public link option
    
    This is possible because metabase#50504
    
    * Always render the embed option
    
    * Fix unit tests
    
    * Fix E2E tests
    
    * Correct test semantic
    
    * Hide Embed option for non-admins
    
    * New Embed modal (#50580)
    
    * Open "Compare options" in a new tab
    
    * Add an external link icon to interactive embed option when it should
    
    * Add disabled state to SDK
    
    * Add a disable state to static and interactive embedding
    
    * Add interactive embedding disabled state
    
    * Implement disabled link
    
    * Prepare folder for testing
    
    * Fix tests and add SDK tests
    
    * Add interactive embedding tests
    
    * Correct test desribe block levels
    
    * Add static embedding tests
    
    * Add premium interactive embedding tests
    
    * Add enterprise tests (EE without tokens)
    
    * Fix the rest of the failed unit tests
    
    * Update E2E tests
    
    * Fix a case where OSS see disabled interactive embedding
    
    This should be impossible as interactive embedding isn't available on
    OSS, so we should not display the disabled state.
    
    * Address review
    
    
    
    * Address review
    
    Co-Authored-by: default avatarPoom <poom@poom.dev>
    
    ---------
    
    
    
    * Update Interactive Embedding Admin Settings page (#50693)
    
    * Add a quick start link to interactive embedding settings page
    
    * Update UTM tags for interactive embedding card
    
    * Don't show interactive embedding option as enabled on OSS
    
    * Fix unit tests
    
    * Add a new test
    
    ---------
    
    Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
    Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
    Streamline embed flow when embedding is off (#50842) (#50979)
    github-automation-metabase authored
    
    * Always show embed sharing option for admins (#50513)
    
    * Always render the public link option
    
    This is possible because metabase#50504
    
    * Always render the embed option
    
    * Fix unit tests
    
    * Fix E2E tests
    
    * Correct test semantic
    
    * Hide Embed option for non-admins
    
    * New Embed modal (#50580)
    
    * Open "Compare options" in a new tab
    
    * Add an external link icon to interactive embed option when it should
    
    * Add disabled state to SDK
    
    * Add a disable state to static and interactive embedding
    
    * Add interactive embedding disabled state
    
    * Implement disabled link
    
    * Prepare folder for testing
    
    * Fix tests and add SDK tests
    
    * Add interactive embedding tests
    
    * Correct test desribe block levels
    
    * Add static embedding tests
    
    * Add premium interactive embedding tests
    
    * Add enterprise tests (EE without tokens)
    
    * Fix the rest of the failed unit tests
    
    * Update E2E tests
    
    * Fix a case where OSS see disabled interactive embedding
    
    This should be impossible as interactive embedding isn't available on
    OSS, so we should not display the disabled state.
    
    * Address review
    
    
    
    * Address review
    
    Co-Authored-by: default avatarPoom <poom@poom.dev>
    
    ---------
    
    
    
    * Update Interactive Embedding Admin Settings page (#50693)
    
    * Add a quick start link to interactive embedding settings page
    
    * Update UTM tags for interactive embedding card
    
    * Don't show interactive embedding option as enabled on OSS
    
    * Fix unit tests
    
    * Add a new test
    
    ---------
    
    Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
    Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
This project manages its dependencies using Yarn. Learn more