Skip to content
Snippets Groups Projects
  • Lena's avatar
    359a8dac
    Clarify that backport/no-backport is an internal thing (#40954) · 359a8dac
    Lena authored
    
    * Clarify that backport/no-backport is an internal thing
    
    A few times per month, external contributors ask about the notion doc they can't access and about the labels they are not expected to set. This is not the experience we should give to people who not only take their time to contribute to metabase, but also actually read the PR template.
    
    (slightly duplicated condition in the beginning and the end of the paragraph — "For those employed [...] If you're not employed [...]" — is on purpose)
    
    * Add linebreaks in PR template
    
    Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
    
    ---------
    
    Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
    Clarify that backport/no-backport is an internal thing (#40954)
    Lena authored
    
    * Clarify that backport/no-backport is an internal thing
    
    A few times per month, external contributors ask about the notion doc they can't access and about the labels they are not expected to set. This is not the experience we should give to people who not only take their time to contribute to metabase, but also actually read the PR template.
    
    (slightly duplicated condition in the beginning and the end of the paragraph — "For those employed [...] If you're not employed [...]" — is on purpose)
    
    * Add linebreaks in PR template
    
    Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
    
    ---------
    
    Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
PULL_REQUEST_TEMPLATE.md 1.45 KiB

[!IMPORTANT] For those employed by Metabase: if you are merging into master, please add either a backport or a no-backport label to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this PR? in the Metabase Branching Strategy document for more details. If you're not employed by Metabase, this section does not apply to you, and the label will be taken care of by your reviewer.

Warning

If that is your first contribution to Metabase, please sign the Contributor License Agreement (unless it's a tiny documentation change). Also, if you're attempting to fix a translation issue, please submit your changes to our POEditor project instead of opening a PR.

Closes https://github.com/metabase/metabase/issues/[issue_number]

Description

Describe the overall approach and the problem being solved.

How to verify

Describe the steps to verify that the changes are working as expected.

  1. New question -> Sample Dataset -> ...
  2. ...

Demo

Upload a demo video or before/after screenshots if sensible or remove the section

Checklist

  • Tests have been added/updated to cover changes in this PR